Skip to content

[15.0][IMP] fieldservice_sale: Show FSM Orders button for own documents users #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Apr 23, 2025
Merged

[15.0][IMP] fieldservice_sale: Show FSM Orders button for own documents users #1337

OCA-git-bot merged 1 commit into from
Apr 23, 2025

Conversation

@ppyczko
Copy link
Contributor

@ppyczko ppyczko commented Mar 7, 2025 •
edited
Loading

The FSM Orders button wasn't visible in the Sale Order view for group_fsm_user_own users.
This [IMP] makes the button accessible, aligning it with the group's access rights.

cc https://github.com/APSL 3553

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 7, 2025

Hi @wolfhall, @brian10048, @max3903,
some modules you are maintaining are being modified, check this out!

@ppyczko ppyczko marked this pull request as ready for review March 7, 2025 07:15
@ppyczko ppyczko changed the title [IMP] fieldservice_sale: Show FSM Orders button for own documents users [15.0][IMP] fieldservice_sale: Show FSM Orders button for own documents users Mar 7, 2025
mpascuall
mpascuall approved these changes Mar 7, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

peluko00
peluko00 approved these changes Mar 7, 2025
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Mar 12, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ppyczko
Copy link
Contributor Author

ppyczko commented Apr 23, 2025

Hi @max3903 @brian10048, sorry to ping directly. Can this be merged?

@max3903 max3903 added this to the 15.0 milestone Apr 23, 2025
@max3903
Copy link
Member

max3903 commented Apr 23, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 23, 2025

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1337-by-max3903-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 23, 2025

Congratulations, your PR was merged at e655dbf. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit a7f1bc9 into OCA:15.0 Apr 23, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max3903 max3903 max3903 approved these changes

+2 more reviewers

@peluko00 peluko00 peluko00 approved these changes

@mpascuall mpascuall mpascuall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved enhancement merged 🎉 ready to merge

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ppyczko @OCA-git-bot @max3903 @peluko00 @mpascuall