Skip to content

[16.0][FIX] hr_holidays_summary_email: change message if empty summary #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

MiquelRForgeFlow
Copy link
Contributor

Avoid having a mail with:

Selection_4019

@OCA-git-bot
Copy link
Contributor

Hi @JordiMForgeFlow,
some modules you are maintaining are being modified, check this out!

@JoanSForgeFlow
Copy link

Hi @MiquelRForgeFlow,

Not receiving any emails can also be a bit confusing. How about we mention in the email that no one is on vacation this week?

Thanks!

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-hr_holidays_summary_email-avoid-empty-summary branch from 31af8fd to a69d197 Compare November 25, 2024 11:01
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-hr_holidays_summary_email-avoid-empty-summary branch from a69d197 to 8da7814 Compare November 25, 2024 11:01
@MiquelRForgeFlow MiquelRForgeFlow changed the title [16.0][IMP] hr_holidays_summary_email: don't send empty summaries [16.0][FIX] hr_holidays_summary_email: change message if empty summary Nov 25, 2024
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Nov 25, 2024

Not receiving any emails can also be a bit confusing.

In my opinion, the empty summary is spam haha

How about we mention in the email that no one is on vacation this week?

Done.

Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing changes 👍🏿

Copy link
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested.

Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MiquelRForgeFlow . Looks good to me

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 30, 2025
@JordiMForgeFlow
Copy link

@OCA/human-resources-maintainers could we get a review and merge here? :)

@dreispt
Copy link
Member

dreispt commented Apr 1, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-151-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 1, 2025
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-151-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants