Skip to content

[14.0][FIX] hr_leave_custom_hour_interval: singleton error on computation of request_hour_from and request_hour_to #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

GSLabIt
Copy link

@GSLabIt GSLabIt commented Apr 28, 2025

No description provided.

@francesco-ooops
Copy link

@OCA/human-resources-maintainers can this be merged? is the same as https://github.com/OCA/hr-holidays/pull/165/files

Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

If it's a backport, it'd be cleaner to have a cherry pick, but for such a small change, it's probably okay anyway.
The commit message should be shorter.

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@francesco-ooops
Copy link

@GSLabIt can you update commit message to [FIX] hr_leave_custom_hour_interval: fix compute_hour functions ?

@GSLabIt
Copy link
Author

GSLabIt commented Apr 28, 2025

Code review, LGTM

If it's a backport, it'd be cleaner to have a cherry pick, but for such a small change, it's probably okay anyway. The commit message should be shorter.

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

it's not a back port ..just found the issue and fixed it

@GSLabIt GSLabIt force-pushed the 14.0-fix-hr_leave_custom_hour_interval-fix_singleton branch from 46309de to 7bb1c11 Compare April 28, 2025 15:53
@GSLabIt
Copy link
Author

GSLabIt commented Apr 28, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @GSLabIt you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Copy link

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok

@francesco-ooops
Copy link

@OCA/human-resources-maintainers can this be merged? is the same as https://github.com/OCA/hr-holidays/pull/165/files

@dreispt @OCA/human-resources-maintainers ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants