-
-
Notifications
You must be signed in to change notification settings - Fork 128
[14.0][FIX] hr_leave_custom_hour_interval: singleton error on computation of request_hour_from and request_hour_to #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0
Are you sure you want to change the base?
Conversation
@OCA/human-resources-maintainers can this be merged? is the same as https://github.com/OCA/hr-holidays/pull/165/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
If it's a backport, it'd be cleaner to have a cherry pick, but for such a small change, it's probably okay anyway.
The commit message should be shorter.
@GSLabIt can you update commit message to [FIX] hr_leave_custom_hour_interval: fix compute_hour functions ? |
it's not a back port ..just found the issue and fixed it |
46309de
to
7bb1c11
Compare
/ocabot merge patch |
Sorry @GSLabIt you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok
@dreispt @OCA/human-resources-maintainers ping :) |
No description provided.