Skip to content

[18.0][MIG] hr_holidays_leave_repeated: Migration to 18.0 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: 18.0
Choose a base branch
from

Conversation

hailangvn
Copy link

  • Multi-employee leave logic has been moved to wizard.
    More details at odoo/odoo@b97b15d

  • leave.resource_calendar_id is computed field and its value is always set.

@hailangvn hailangvn force-pushed the 18.0-mig-hr_holidays_leave_repeated branch from fcf1417 to 42f9304 Compare May 26, 2025 01:27
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally since Runboat seems to be on an older Odoo version (raising error linked to old Odoo hr_holidays code)
LGTM
Would you mind reviewing the 2 PR for v16 and v17 that you have included in this module history : #158 and #160 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants