[17.0][FIX+IMP] hr_holidays_natural_period: Hide Half day option in leaves if natural_day is selected + natural_day_half_day option

[victoralmau]

FWP from 16.0: #192

Continuation of #191

hr_holidays_natural_period: Hide Half day option in leaves if natural_day is selected

Before

After

Extra changes done:

• hr_holidays_natural_period: Add Natural day (Half day) option (natural_day_half_day)
• hr_holidays_natural_period: Adding tests to cover cases with natural_day_half_day

Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?

@Tecnativa TT56402

[carlos-lopez-tecnativa]

Sorry, but I don't fully understand the behavior of the new natural_day_half_day option. I have the following scenario:

Two time off types: one configured as half day and another with natural_day_half_day.

But when I assign the time off, the new option counts full days. I expected it to count half days instead.
Is this not the expected behavior?

[pedrobaeza]

The "half-day" option is to allow to have the check to put the half day. Some may not be interested in allow you half-day on your time-offs, so you restrict it. But when ticking it and selecting half-day, the leave should be 0.5. Isn't that working?

[carlos-lopez-tecnativa]

The "half-day" option is to allow to have the check to put the half day. Some may not be interested in allow you half-day on your time-offs, so you restrict it. But when ticking it and selecting half-day, the leave should be 0.5. Isn't that working?

I hope it works as you described, but please take a look at my screenshots, this new option is counting full days.

[pedrobaeza]

Then that can be considered incorrect indeed.