Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_fr_ecotaxe: Migration to 17.0 #550

Merged
merged 40 commits into from
Jun 5, 2024

Conversation

yankinmax
Copy link
Contributor

@yankinmax yankinmax commented Jun 3, 2024

Depends on:
Migration to v16

mourad-ehm and others added 9 commits June 3, 2024 16:01
[14.0][IMP] l10n_fr_ecotaxe: manage multi ecotaxe classification by product

[14.0][FIX] l10n_fr_ecotaxe: pre-commit, access rule, view

[14.0][FIX] l10n_fr_ecotaxe: imp multi ecotaxe classification on product form & edit ecotaxe line on account move line

[14.0][FIX] l10n_fr_ecotaxe: add archived web_ribbon on ecotaxe_classification & ecotaxe_category

[14.0][FIX] l10n_fr_ecotaxe: fix tests

[14.0][FIX] l10n_fr_ecotaxe: fix _onchange_product_ecotaxe_line

[16.0][FIX] fix pre-commit & typo

[16.0][FIX] update readme files
[16.0][FIX] product variant view

[16.0][FIX] add unique sql constaint for ecotaxe classif on product
[16.0][IMP]  rename fields in l10n_fr_ecotaxe module rest of modif & imp product view
[16.0][FIX] fix psot-migration view load bug

[16.0][FIX] fix digits precision for ecotaxe amount on invoice & product & fixed ecotaxe

[16.0][FIX] tests

[16.0][FIX] replace onchange by compute

[16.0][FIX] pre-commit
Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration LGTM, only non-blocking remarks :)

l10n_fr_ecotaxe/models/ecotaxe_line_product.py Outdated Show resolved Hide resolved
@yankinmax yankinmax force-pushed the 17.0-mig-l10n_fr_ecotaxe branch from 6211445 to 9e439f5 Compare June 4, 2024 08:22
@yankinmax yankinmax force-pushed the 17.0-mig-l10n_fr_ecotaxe branch from 9e439f5 to 173c14f Compare June 5, 2024 10:32
Copy link

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-550-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fc949c9 into OCA:17.0 Jun 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cec09ad. Thanks a lot for contributing to OCA. ❤️

@bealdav
Copy link
Member

bealdav commented Jun 5, 2024

You problably need to revert in your project if it's possible because of

https://github.com/OCA/account-fiscal-rule/pulls/mourad-ehm

cc @yankinmax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants