-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] fix: remove access to all models, allow selection of reports #3335
Conversation
…ttings' area can export electronic invoice" This reverts commit 4f1747e.
@@ -53,6 +57,8 @@ def saveAttachment(self, fatturapa, number): | |||
|
|||
attach_str = fatturapa.to_xml(self.env) | |||
attach_vals = { | |||
"res_model": "fatturapa.attachment.out", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queste modifiche, è meglio includerle in un commit separato (o PR), accompagnato/a da una issue dedicata, così come si era deciso venerdì 😉 Grazie 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hai anche tu ragione
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3336
mo' faccio la PR
Per quanto riguarda un test, secondo me è un discorso molto più generale sul fatto che i test andrebbero TUTTI eseguiti come utente normale. Lo si potrebbe anche aggiungere uno per questo caso che fa una search() del modello degli allegati come utente normale, ma in realtà andrebbero modificati tutti. |
Nella |
/ocabot merge patch |
On my way to merge this fine PR! |
@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3335-by-tafaRU-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@TheMule71 il merge command fallisce per via di #3366 |
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at e779768. Thanks a lot for contributing to OCA. ❤️ |
Also allow export xml file without belonging to Invoicing/Billing Administrator group
Also allow export xml file without belonging to Invoicing/Billing Administrator group
#3317 permetteva l'accesso a tutti i modelli da parte del gruppo
group_account_invoice
Pur risolvendo il problema specifico (il wizard per esportare le fatture deve avere accesso a
ir.actions.report
) lo scope della modifica è molto più ampio.Questa PR usa
sudo()
per interrogare il modello dove serve.