Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] fix: remove access to all models, allow selection of reports #3335

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

TheMule71
Copy link
Contributor

#3317 permetteva l'accesso a tutti i modelli da parte del gruppo group_account_invoice
Pur risolvendo il problema specifico (il wizard per esportare le fatture deve avere accesso a ir.actions.report) lo scope della modifica è molto più ampio.

Questa PR usa sudo() per interrogare il modello dove serve.

…ttings' area can export electronic invoice"

This reverts commit 4f1747e.
@@ -53,6 +57,8 @@ def saveAttachment(self, fatturapa, number):

attach_str = fatturapa.to_xml(self.env)
attach_vals = {
"res_model": "fatturapa.attachment.out",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queste modifiche, è meglio includerle in un commit separato (o PR), accompagnato/a da una issue dedicata, così come si era deciso venerdì 😉 Grazie 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hai anche tu ragione

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3336
mo' faccio la PR

@TheMule71
Copy link
Contributor Author

Per quanto riguarda un test, secondo me è un discorso molto più generale sul fatto che i test andrebbero TUTTI eseguiti come utente normale. Lo si potrebbe anche aggiungere uno per questo caso che fa una search() del modello degli allegati come utente normale, ma in realtà andrebbero modificati tutti.

@SirTakobi
Copy link
Contributor

SirTakobi commented May 29, 2023

Per quanto riguarda un test, secondo me è un discorso molto più generale sul fatto che i test andrebbero TUTTI eseguiti come utente normale. Lo si potrebbe anche aggiungere uno per questo caso che fa una search() del modello degli allegati come utente normale, ma in realtà andrebbero modificati tutti.

Nella 16.0 è così, l'avevo aggiunto in TheMule71@98bb653 quindi puoi prendere spunto (cherry-pick no perché è un altro modulo) da lì.
Poi il tutto è stato schiacciato nel commit di migrazione 615c6dd

@tafaRU
Copy link
Member

tafaRU commented Jun 9, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3335-by-tafaRU-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 9, 2023
Signed-off-by tafaRU
@OCA-git-bot
Copy link
Contributor

@tafaRU your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3335-by-tafaRU-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@tafaRU
Copy link
Member

tafaRU commented Jun 9, 2023

@TheMule71 il merge command fallisce per via di #3366

@tafaRU
Copy link
Member

tafaRU commented Jun 9, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3335-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 17c4741 into OCA:14.0 Jun 9, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e779768. Thanks a lot for contributing to OCA. ❤️

tafaRU added a commit to tafaRU/l10n-italy that referenced this pull request Jun 26, 2023
tafaRU added a commit to tafaRU/l10n-italy that referenced this pull request Jun 26, 2023
tafaRU added a commit that referenced this pull request Jun 29, 2023
tafaRU added a commit to tafaRU/l10n-italy that referenced this pull request Jun 29, 2023
Also allow export xml file without belonging to Invoicing/Billing Administrator group
OCA-git-bot pushed a commit to tafaRU/l10n-italy that referenced this pull request Feb 28, 2024
Also allow export xml file without belonging to Invoicing/Billing Administrator group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants