Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] l10n_it_delivery_note: fix ddt reference in invoice #4119

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Apr 29, 2024

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @aleuffre, @renda-dev, @MarcoCalcagni,
some modules you are maintaining are being modified, check this out!

@tafaRU
Copy link
Member

tafaRU commented May 3, 2024

@Borruso potresti per favore aprire la issue di riferimento?

@Borruso
Copy link
Contributor Author

Borruso commented May 3, 2024

@Borruso potresti per favore aprire la issue di riferimento?

Fatto

@francesco-ooops francesco-ooops linked an issue May 3, 2024 that may be closed by this pull request
@Borruso Borruso force-pushed the 14.0-fix-ddt_invoice_reference branch 2 times, most recently from 9a4def5 to a30c302 Compare May 8, 2024 08:58
@Borruso Borruso force-pushed the 14.0-fix-ddt_invoice_reference branch from a30c302 to 21ed84c Compare July 26, 2024 08:12
Copy link
Contributor

@PicchiSeba PicchiSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: failing tests

@@ -734,14 +734,16 @@ def action_invoice(self, invoice_method=False):
)
if not sale_ids:
continue

delivery_notes = sale_ids.mapped("delivery_note_ids") & self
Copy link
Contributor

@PicchiSeba PicchiSeba Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test falliscono perché delivery_note_ids non è un campo di sale.order, ma solo di account.move (viene aggiunto sul SO dal modulo l10n_it_delivery_note_order_link).
Potremmo mappare su invoice_ids.delivery_note_ids ma non so se sia corretto.

@Borruso Borruso force-pushed the 14.0-fix-ddt_invoice_reference branch from 21ed84c to aff93c3 Compare November 4, 2024 09:54
@Borruso Borruso force-pushed the 14.0-fix-ddt_invoice_reference branch from aff93c3 to 3730a2f Compare November 4, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIX DdT Reference in Invoice
4 participants