Skip to content

[FIX] l10n_it_fatturapa_in: allow use of our account in payment info #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[FIX] l10n_it_fatturapa_in: allow use of our account in payment info #4223

wants to merge 1 commit into from

Conversation

matteoopenf
Copy link
Contributor

@matteoopenf matteoopenf commented Jun 20, 2024 •
edited by francesco-ooops
Loading

Fixes #4220

@matteoopenf matteoopenf marked this pull request as ready for review June 20, 2024 15:11
@matteoopenf matteoopenf mentioned this pull request Jun 20, 2024
Open
3 tasks
@francesco-ooops francesco-ooops linked an issue Jun 20, 2024 that may be closed by this pull request
[l10n_it_fatturapa_in] importazione conto in caso di riba errore duplicazione conto #4220
Open
3 tasks
@francesco-ooops
Copy link
Contributor

@matteoopenf che problema c'è con i test?

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jun 27, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test: OK

@SirAionTech SirAionTech added the needs fixing Has conflicts or is failing mandatory CI checks label Aug 21, 2024
@matteoopenf
Copy link
Contributor Author

@matteoopenf che problema c'è con i test?

in questi giorni provo a vedere il problema ai test intanto ho fatto rebase che i log non c'erano più

@SirAionTech SirAionTech added the is porting This pull request is porting a change from another version label Nov 11, 2024
@TheMule71 TheMule71 mentioned this pull request Nov 15, 2024
Open
35 tasks
@tafaRU
Copy link
Member

tafaRU commented Nov 15, 2024

@matteoopenf hai modo di correggere i test?

@matteoopenf
Copy link
Contributor Author

matteoopenf commented Dec 13, 2024 •
edited
Loading

@matteoopenf hai modo di correggere i test?

provo se hai un hint e' gradito

@matteoopenf
Copy link
Contributor Author

@tafaRU ho provato a vedere, ma non riesco a capire come fixare il test se mi dai un aiuto fixo il test o se vuoi fare una pr verso la mia te la accetto volentieri

@matteoopenf matteoopenf force-pushed the 16.0-portPr1979 branch 2 times, most recently from 90c2341 to 14b73fd Compare December 18, 2024 14:49
patrickt-oforce
patrickt-oforce reviewed Jan 31, 2025
View reviewed changes
l10n_it_fatturapa_in/tests/test_import_fatturapa_xml.py
}
)
to_unlink.append(bank_account)
res = self.run_wizard("test55", "IT01234567890_FPR15.xml")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test falliscono perché il valore test55 è usato anche in test_54_xml_in_invoice_registration_date_rec_date come valore per il wizard a riga 970

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteoopenf hai idea del perchè questo test non falliva sulla 14?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sinceramente no, non ho capito perche' fallisce solo di qua, @patrickt-oforce mi ha dato un input, ma devo tornarci sopra

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quello che credo e' che nel porting di altri moduli siano stati fixati i test e quindi ci sia per quello l'errore

@matteoopenf matteoopenf mentioned this pull request Apr 16, 2025
Merged
@francesco-ooops
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesco-ooops francesco-ooops francesco-ooops left review comments

@patrickt-oforce patrickt-oforce patrickt-oforce left review comments

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
16.0 is porting This pull request is porting a change from another version needs fixing Has conflicts or is failing mandatory CI checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[l10n_it_fatturapa_in] importazione conto in caso di riba errore duplicazione conto
8 participants
@matteoopenf @francesco-ooops @tafaRU @OCA-git-bot @patrickt-oforce @MaurizioPellegrinet @SirAionTech @TheMule71