[16.0][MIG] l10n_es_pos: Migration to 16.0 #2615

danielduqma · 2022-11-21T10:13:32Z

rafaelbn · 2022-11-21T17:41:34Z

Aquí ya debe de quedar definitivamente corregido este problema #2582 para no tener que hacer cambios complicados en una misma versión que hace que 2 tipos de instancias sean incompatibles.

pedrobaeza · 2023-02-09T08:59:43Z

/ocabot migration l10n_es_pos

l10n_es_pos/models/pos_order.py

danielduqma · 2023-04-04T10:02:25Z

Se ha rebaseado el desarrollo y se han aplicado los cambios aprobados en #2812 para este módulo en la rama 14.0.

chienandalu · 2023-04-05T13:01:25Z

Ten en cuenta también algunos cambios que ha habido que adaptar en el FW que se ha hecho en #2965

) This way we don't need to make glue modules over l10n_es_pos every time we need to make use of that info for a generic purpose.

Currently translated at 100.0% (31 of 31 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_pos Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_pos/es/

POS config names can be repeated, for example when running `point_of_sale` tests. Hence, created sequences would be duplicated, so with this change this is checked and prevented adding a suffix.

danielduqma · 2023-04-10T10:15:02Z

Ten en cuenta también algunos cambios que ha habido que adaptar en el FW que se ha hecho en #2965

Hecho! He aplicado los cambios del 15.0 en el histórico de la rama.

flachica · 2023-04-28T09:58:21Z

l10n_es_pos/static/src/js/PaymentScreen.js

+                        order.to_invoice = true;
+                    }
+                }
+                super.validateOrder(isForceValidate);


Suggested change

super.validateOrder(isForceValidate);

await super.validateOrder(isForceValidate);

Corregido, gracias por la revisión!

Change made in 1baf50b avoids showing customer popup on orders above limit (invoiced). Moving back logic to `validateOrder` fixes this problem.

fcvalgar

Revisión funcional.

Perfecto el proceso de validación. Muy intuitivo y claro.

https://www.awesomescreenshot.com/video/17092554?key=6af6d010c88d816f27488b2f43775b96

Gracias @danielduqma.

RodrigoBM · 2023-05-24T11:49:48Z

@oca/local-spain-maintainers ¿Alguien puede mergear el PR?

rafaelbn

¡Gran trabajo a todos!

@omar7r tu que eres experto de POS 😄 y PSC?

@chienandalu de acuerdo?

@pedrobaeza te animas?

pedrobaeza · 2023-05-24T12:43:25Z

Necesito la confirmación de alguien de PoS.

rafaelbn · 2023-05-24T12:58:29Z

@pedrobaeza yo lo he probado y soy PSC de PoS, ¿No te sirvo? 😄

pedrobaeza · 2023-05-24T13:00:48Z

Es una review técnica de JavaScript, Rafa.

rafaelbn · 2023-05-24T13:01:44Z

Aquí tienes la review funcional: https://www.loom.com/share/c9dc6f97080d4d0fb4f188b782370cee

He revisado tanto funcionamiento como secuencias y desglose correcto de impuestos, como operativa para complir con la normativa.

zamberjo · 2023-06-06T10:29:56Z

Hola, puedes incluir el FIX #3066 (15.0) (14.0 #3053)?

chienandalu

👍

pedrobaeza · 2023-06-06T10:48:12Z

/ocabot merge nobump

OCA-git-bot · 2023-06-06T10:48:18Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2615-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-06-06T11:04:09Z

Congratulations, your PR was merged at f25f6ca. Thanks a lot for contributing to OCA. ❤️

RodrigoBM · 2023-06-06T11:09:04Z

Hola, puedes incluir el FIX #3066 (15.0) (14.0 #3053)?

No le ha dado a mi compañero a añadirlo antes del mergeo, ¿puedes crear un PR con el fix y lo revisamos?

zamberjo · 2023-06-06T11:17:16Z

Si, estoy en ello

danielduqma force-pushed the 16.0-mig-l10n_es_pos branch from dfd97f0 to b2fc63a Compare November 21, 2022 11:00

danielduqma marked this pull request as ready for review November 22, 2022 07:14

danielduqma force-pushed the 16.0-mig-l10n_es_pos branch from b2fc63a to d238117 Compare November 29, 2022 16:45

OCA-git-bot added this to the 16.0 milestone Feb 9, 2023

OCA-git-bot mentioned this pull request Feb 9, 2023

Migration to version 16.0 #2526

Open

51 tasks

This was referenced Feb 13, 2023

[14.0][IMP] l10n_es_pos: Secuencias por dispositivo #2812

Merged

[14.0][FIX] l10n_es_pos: offline simplified number #2582

Closed

flachica suggested changes Feb 28, 2023

View reviewed changes

l10n_es_pos/models/pos_order.py Outdated Show resolved Hide resolved

danielduqma force-pushed the 16.0-mig-l10n_es_pos branch 2 times, most recently from 33a789b to e546f36 Compare March 16, 2023 20:17

danielduqma force-pushed the 16.0-mig-l10n_es_pos branch from 31b725c to eb9fcf7 Compare April 4, 2023 09:21

Endika Iglesias and others added 15 commits April 5, 2023 17:03

[ADD] Add l10n_es_pos

75f2778

[UPD] prefix versions with 8.0

5f38135

[FIX] remove en.po that was erroneously created by transbot

6e3aac2

[MIG] l10n_es_pos

e9eb144

[ADD] l10n_es_pos: posbox support and translations

3cda889

[MIG] l10n_es_pos: Migration to 11.0

eef58cf

[FIX] l10n_es_pos: typo in oldname (OCA#886)

41c0779

[IMP] l10n_es_pos: Handle the sequence properly (OCA#902)

84dd9da

[FIX] l10n_es_pos: Import uninstall_hook

8399366

[IMP] l10n_es_pos: move simpl. inv. reference to standard field (OCA#945

0d9b115

) This way we don't need to make glue modules over l10n_es_pos every time we need to make use of that info for a generic purpose.

[MIG] l10n_es_pos: Migration to 12.0

3afd887

Translated using Weblate (Spanish)

fe00bd9

Currently translated at 100.0% (31 of 31 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_pos Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_pos/es/

[FIX] l10n_es_pos: XmlReceipt doesn't show customer

cb5799b

[FIX] l10n_es_pos: prevent duplicate or missing orders

0b8c33a

[FIX] l10n_es_pos: errors due to context

9707615

suker and others added 2 commits April 10, 2023 12:03

[DEL] l10n_es_pos: deleting duplicated field

3077205

[FIX] l10n_es_pos: duplicated POS names

9270da5

POS config names can be repeated, for example when running `point_of_sale` tests. Hence, created sequences would be duplicated, so with this change this is checked and prevented adding a suffix.

danielduqma force-pushed the 16.0-mig-l10n_es_pos branch from 6a2e854 to 8b6615c Compare April 10, 2023 10:08

fcvalgar mentioned this pull request Apr 27, 2023

[15][BUG] l10n_es_pos - Error en la validación del límite de factura simplificada #3015

Closed

flachica suggested changes Apr 28, 2023

View reviewed changes

[FIX] l10n_es_pos: validation

bb5ee01

Change made in 1baf50b avoids showing customer popup on orders above limit (invoiced). Moving back logic to `validateOrder` fixes this problem.

danielduqma force-pushed the 16.0-mig-l10n_es_pos branch from 8b6615c to bb5ee01 Compare April 28, 2023 11:31

flachica approved these changes Apr 28, 2023

View reviewed changes

fcvalgar approved these changes May 4, 2023

View reviewed changes

OCA-git-bot added the approved label May 4, 2023

RodrigoBM approved these changes May 24, 2023

View reviewed changes

rafaelbn approved these changes May 24, 2023

View reviewed changes

SoniaViciana mentioned this pull request Jun 5, 2023

Envíos al SII automáticos desde el POS #3058

Closed

chienandalu approved these changes Jun 6, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 6, 2023

OCA-git-bot merged commit 5928e95 into OCA:16.0 Jun 6, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] l10n_es_pos: Migration to 16.0 #2615

[16.0][MIG] l10n_es_pos: Migration to 16.0 #2615

danielduqma commented Nov 21, 2022

rafaelbn commented Nov 21, 2022

pedrobaeza commented Feb 9, 2023

danielduqma commented Apr 4, 2023

chienandalu commented Apr 5, 2023

danielduqma commented Apr 10, 2023

flachica Apr 28, 2023

danielduqma Apr 28, 2023

fcvalgar left a comment •

edited

Loading

RodrigoBM commented May 24, 2023

rafaelbn left a comment

pedrobaeza commented May 24, 2023

rafaelbn commented May 24, 2023

pedrobaeza commented May 24, 2023

rafaelbn commented May 24, 2023

zamberjo commented Jun 6, 2023

chienandalu left a comment

pedrobaeza commented Jun 6, 2023

OCA-git-bot commented Jun 6, 2023

OCA-git-bot commented Jun 6, 2023

RodrigoBM commented Jun 6, 2023

zamberjo commented Jun 6, 2023

	super.validateOrder(isForceValidate);
	await super.validateOrder(isForceValidate);

[16.0][MIG] l10n_es_pos: Migration to 16.0 #2615

[16.0][MIG] l10n_es_pos: Migration to 16.0 #2615

Conversation

danielduqma commented Nov 21, 2022

rafaelbn commented Nov 21, 2022

pedrobaeza commented Feb 9, 2023

danielduqma commented Apr 4, 2023

chienandalu commented Apr 5, 2023

danielduqma commented Apr 10, 2023

flachica Apr 28, 2023

Choose a reason for hiding this comment

danielduqma Apr 28, 2023

Choose a reason for hiding this comment

fcvalgar left a comment • edited Loading

Choose a reason for hiding this comment

RodrigoBM commented May 24, 2023

rafaelbn left a comment

Choose a reason for hiding this comment

pedrobaeza commented May 24, 2023

rafaelbn commented May 24, 2023

pedrobaeza commented May 24, 2023

rafaelbn commented May 24, 2023

zamberjo commented Jun 6, 2023

chienandalu left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jun 6, 2023

OCA-git-bot commented Jun 6, 2023

OCA-git-bot commented Jun 6, 2023

RodrigoBM commented Jun 6, 2023

zamberjo commented Jun 6, 2023

fcvalgar left a comment •

edited

Loading