[15.0][MIG] payment_redsys: Migration to version 15.0 #2968

sergio-teruel · 2023-04-01T08:00:20Z

ping @chienandalu @CarlosRoca13 @luisplanes

superseded #2149 and last changes

@luisplanes Te he añadido como autor y contrubuidor por los cambios de tu PR. Gracias.

pedrobaeza · 2023-04-01T09:24:42Z

/ocabot migration payment_redsys

OCA-git-bot · 2023-04-01T09:24:56Z

The migration issue (#1866) has been updated to reference the current pull request.
however, a previous pull request was referenced : #2149.
Perhaps you should check that there is no duplicate work.
CC : @luisplanes

* Corregido error en caso de que refence no este informado, al renderizar la plantilla del boton de pago. * Corregido error que no permite pagar por transferencia al instalar el modulo payment_redsys * Añadidas descripciones de los productos de la cesta a la clave 'DS_Merchant_ProductDescription'.

* Make quotation sending optional when a transaction ends without error website_sale module already sends an e-mail with the confirmed order, so it May not be necessary to send another e-mail with the same order unconfirmed. * Add more Redsys frontend languages * Remove options tab

* Send quotation e-mail invoking force_quotation_send() instead of action_quotation_send() + send_mail() * The function send_mail() does not respect the context language so the email is always sent in English. * It's not necessary to create the function send_mail() to sent an email when exists the method force_quotation_send(). * Add detailed error info

…r payment + Default values for urk_KO and url_OK + option to print print sale report. Delete url_ok and url_ko fields + Redondeo de merchant_amount

The discount is shown on the order summary if the current user is a member of sale.group_discount_per_so_line group OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[IMP] payment_redsys: Allow partial payment by percent

Includes to allow show order for unauthenticated users

When we have an order sequence of length six (SO123456), the signature process fails with the following message: Server Error: We are not able to redirect you to the payment form. 'str' object has no attribute 'decode'

Currently translated at 71.6% (48 of 67 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (67 of 67 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (67 of 67 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/

- JSON request: For a JSON request there's no website attribute. This is the case for payment links. We try to fallback to context if it has the `website_id` in it. Otherwise, `web.base.url` will be our last resource as usual. TT34154 - wrong reference TT34312

pycrypto is unmaintained since several ago, and in fact pycryptodome was the library being used in previous version. The API we are using is compatible between both libraries though. There's no problem for already deployed systems, as the check on the external dependencies is only done at install. We took the occasion to remove the try mechanism that is not needed now, although the linter emits a warning.

We're sending the string template without parameters to the method _set_transcation_error() so no info is shown. TT41589

pedrobaeza · 2023-04-01T09:54:32Z

/ocabot merge nobump

OCA-git-bot · 2023-04-01T09:54:41Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2968-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2023-04-01T10:10:51Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-2968-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2023-04-01T10:13:47Z

/ocabot merge nobump

OCA-git-bot · 2023-04-01T10:13:53Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2968-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2023-04-01T10:31:11Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-2968-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2023-04-01T10:37:08Z

/ocabot merge nobump

OCA-git-bot · 2023-04-01T10:37:15Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2968-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-04-01T11:06:25Z

Congratulations, your PR was merged at 3cca688. Thanks a lot for contributing to OCA. ❤️

Ranamiu · 2023-04-03T12:38:36Z

Thanks @sergio-teruel @OCA-git-bot @pedrobaeza

Having a issue, cannot install on latest 15 - Odoo 15.0-20230331 (Versión Community).

Please, might you try installing, please, on your side ?

Appreciate

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 643, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/usr/lib/python3/dist-packages/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
odoo.tools.convert.ParseError: while parsing /usr/lib/python3/dist-packages/odoo/.local/share/Odoo/addons/15.0/payment_redsys/data/payment_redsys.xml:38, somewhere inside
<record id="payment_method_redsys" model="account.payment.method">
        <field name="name">Redsys</field>
        <field name="code">redsys</field>
        <field name="payment_type">inbound</field>
    </record>

pedrobaeza · 2023-04-03T13:00:09Z

The log entry is ripped and the significant part is missing, but anyway, that seems something on your side, as the module installs in a fresh DB like the runboat.

Ranamiu · 2023-04-03T14:33:32Z

Yes, you are 100% right.

Apologies.

Tried on a fresh DB and instalaltion OK.

Me, should have read carefully the detailed error log.

Our fault: we are on running database and probably issue is due to an older module previously installed:

psycopg2.IntegrityError: duplicate key value violates unique constraint "account_payment_method_name_code_unique"
DETAIL:  Key (code, payment_type)=(redsys, inbound) already exists.

Again, apologies !!

Best regards

OCA-git-bot added this to the 15.0 milestone Apr 1, 2023

OCA-git-bot mentioned this pull request Apr 1, 2023

Migration to version 15.0 #1866

Open

48 tasks

pedrobaeza mentioned this pull request Apr 1, 2023

[15.0][MIG] payment_redsys: Migration to 15.0 #2149

Closed

sergio-teruel and others added 25 commits April 1, 2023 11:28

[ADD] Nuevo modulo para pagos con tajeta (sermepa-redsys)

219d21d

[DEL] No crear un pago redsys por defecto al instalar

40a74d8

[FIX] payment_redsys: New module

a79877e

[IMP] payment_redsys: Migracion a HMAC SHA-256

7a00e50

[FIX] payment_redsys: Renaming class name yields unwanted side effect.

a7f4a43

[IMP] payment_redsys: Change payment logo

9e18356

[IMP] payment_redsys: Change card icon in checkout process.

3bd6ff5

[IMP+FIX] payment_redsys: Logo tarjetas + Show order information afte…

d6fcda7

…r payment + Default values for urk_KO and url_OK + option to print print sale report. Delete url_ok and url_ko fields + Redondeo de merchant_amount

[IMP][8.0] payment_redsys: Pagar un porcentaje del pedido (OCA#362)

bad62fa

[IMP] payment_redsys: Allow partial payment by percent

[MIG] payment_redsys: Migration to v9

60dec04

Includes to allow show order for unauthenticated users

[MIG] payment_redsys: Migrated to 10.0

fded338

[11.0][MIG] payment_redsys: Migration

6221efc

[chg] Dependency from abandoned pycrypto to pycryptodome

d375a72

[FIX] payment_redsys: Fix signature

54339a2

When we have an order sequence of length six (SO123456), the signature process fails with the following message: Server Error: We are not able to redirect you to the payment form. 'str' object has no attribute 'decode'

[IMP] payment_redsys: README by fragments

627e08a

[12.0][MIG] payment_redsys: Better test coverage

2e21d7f

[IMP] payment_redsys: Better status code check

5d9fa08

[FIX] payment_redsys: Process order after gateway payment successful

77c9ea8

[IMP] account_multicompany_easy_creation: black, isort, prettier

add0097

[MIG] payment_redsys: Migration to v13.0

2f33740

pedrobaeza and others added 6 commits April 1, 2023 11:31

[IMP] payment_redsys: Put real package on pypi

e7c54ad

[FIX] payment_redsys: feedback error string format

b94331b

We're sending the string template without parameters to the method _set_transcation_error() so no info is shown. TT41589

[IMP] payment_redsys: black, isort

9540742

[MIG] payment_redsys: Migration to v15.0

e31ff41

pedrobaeza force-pushed the 15.0-mig-payment_redsys branch from 1f2f27f to e31ff41 Compare April 1, 2023 09:33

OCA-git-bot added the bot is merging ⏳ label Apr 1, 2023

OCA-git-bot added a commit that referenced this pull request Apr 1, 2023

Merge PR #2968 into 15.0

77565eb

Signed-off-by pedrobaeza

OCA-git-bot removed the bot is merging ⏳ label Apr 1, 2023

OCA-git-bot added the bot is merging ⏳ label Apr 1, 2023

OCA-git-bot added a commit that referenced this pull request Apr 1, 2023

Merge PR #2968 into 15.0

593366f

Signed-off-by pedrobaeza

OCA-git-bot removed the bot is merging ⏳ label Apr 1, 2023

OCA-git-bot added the bot is merging ⏳ label Apr 1, 2023

OCA-git-bot merged commit f252bc0 into OCA:15.0 Apr 1, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 1, 2023

pedrobaeza deleted the 15.0-mig-payment_redsys branch April 1, 2023 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] payment_redsys: Migration to version 15.0 #2968

[15.0][MIG] payment_redsys: Migration to version 15.0 #2968

sergio-teruel commented Apr 1, 2023 •

edited

Loading

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

Ranamiu commented Apr 3, 2023

pedrobaeza commented Apr 3, 2023

Ranamiu commented Apr 3, 2023 •

edited

Loading

[15.0][MIG] payment_redsys: Migration to version 15.0 #2968

[15.0][MIG] payment_redsys: Migration to version 15.0 #2968

Conversation

sergio-teruel commented Apr 1, 2023 • edited Loading

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

pedrobaeza commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

OCA-git-bot commented Apr 1, 2023

Ranamiu commented Apr 3, 2023

pedrobaeza commented Apr 3, 2023

Ranamiu commented Apr 3, 2023 • edited Loading

sergio-teruel commented Apr 1, 2023 •

edited

Loading

Ranamiu commented Apr 3, 2023 •

edited

Loading