Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] l10n_es_igic: Refactorizado y recuperación de ids anteriores #3866

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[17.0][FIX] l10n_es_igic: Refactorizado y recuperación de ids anteriores #3866

merged 1 commit into from
Dec 23, 2024

Conversation

Christian-RB
Copy link
Contributor

Este PR corrige el módulo de l10n_es_igic, recuperándo los xml_ids anteriores y eliminando toda la contabilidad repetida.
@pedrobaeza @etobella

@Christian-RB
Copy link
Contributor Author

Issue #3864

@pedrobaeza pedrobaeza added this to the 17.0 milestone Dec 21, 2024
pedrobaeza
pedrobaeza approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sin ir línea a línea, tiene buena pinta. La anterior versión se cargaba el plan contable de l10n_es.

@pedrobaeza pedrobaeza requested a review from etobella December 21, 2024 08:37
etobella
etobella approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funcionalmente funciona bien.

Faltaría ver si es necesario hacer scripts de migración.

@pedrobaeza
Copy link
Member

Fusiono por el momento para que no haya más posible gente que instale la versión anterior:

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3866-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 249c2e6 into OCA:17.0 Dec 23, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 71d5fc3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Christian-RB @pedrobaeza @OCA-git-bot @etobella