[MIG] l10n_es_aeat_sii_oca: Migration to v18 #4046
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comenzaré de cero después de los muchos cambios que han habido en la 17.0 |
AaronHForgeFlow
changed the title
|
Aarón, espera un poco más, que voy a hacer algunos cambios. Y luego nos reunimos para ver cómo atacar lo de los certificados. Luego te contacto por Matrix. |
AaronHForgeFlow
force-pushed
the
18.0-mig-l10n_es_aeat_sii_oca
branch
from
5e7ab1f to
69a189b
Compare
AaronHForgeFlow
force-pushed
the
18.0-mig-l10n_es_aeat_sii_oca
branch
from
69a189b to
2efe91f
Compare
AaronHForgeFlow
force-pushed
the
18.0-mig-l10n_es_aeat_sii_oca
branch
from
2efe91f to
5ef4904
Compare
AaronHForgeFlow
changed the title
|
Probado con certificado en la web de la AEAT para pruebas, tanto con facturas de cliente como de compra e incluyendo cancelación. Ready to review. |
|
/ocabot migration l10n_es_aeat_sii_oca |
|
A tener en cuenta #4202 |
|
Hay que incluir #4254 |
AaronHForgeFlow
force-pushed
the
18.0-mig-l10n_es_aeat_sii_oca
branch
2 times, most recently
from
d748579 to
8751be0
Compare
|
@AaronHForgeFlow @pedrobaeza Cómo va avanzando el SII? Revisasteis lo que comentasteis de los certificados? Por saber si puedo empezar con las validaciones del PR. Gracias. |
|
Hola @HaraldPanten Lo miramos en los OCA Days y como no estaba nada claro que usar los nuevos ceritificados fuera mejor, ni si Odoo introducirá nuevos cambios en nuevas versiones de momento lo dejamos tal cuál. Siempre se puede hacer otra PR como mejora más adelante. También hicimos un par de pruebas funcionales en modo test y fue bien. Así que lo podéis revisar :) |
|
Perfecto! Pues miraré de atacarlo a partir de las próximas semanas 👍 |
AaronHForgeFlow
force-pushed
the
18.0-mig-l10n_es_aeat_sii_oca
branch
from
8751be0 to
17da622
Compare
* Filtro de no enviados SII que sólo incluya 2017 * Los trabajos no realizados se eliminan en lugar de pasarlos a estado "Hecho" al reenviar, cancelar, etc. * Permiso de lectura a queue.job para los gestores de la AEAT. * Regla de seguridad para que los gestores de la AEAT sólo vean los trabajos del SII. * Los trabajos se encolan como admin para evitar errores al validar por gente sin permisos del conector. Desafortunadamente, no se puede mantener el usuario original en el trabajo. [IMP] l10n_es_aeat_sii: Share queue.job view for both types of invoices [FIX] l10n_es_aeat_sii: Add jobs with sudo for avoiding permission errors [FIX] l10n_es_aeat_sii: Permissions problem No more need for connector or AEAT permissions [IMP] l10n_es_aeat_sii: Track content sent + better layout for return
[IMP] l10n_es_aeat_sii: Change tax computation to invoice level Odoo v9 already knows which tax generates each invoice tax line, so we get with this: * Avoid to make roundings that are not accurate. * If there are manual changes in supplier invoices taxes, now we will be able to notify them and prevent not matching errors. * Less difficult algorithms for getting tax amount totals.
…ialmente Correcto'
…er method Since odoo/odoo@07be14e3086f473ed9a8c4b12ea7c, Odoo has a helper method in AccountTestInvoicingCommon called `_create_invoice`. There are some tests here in this repository using the same name for methods with the decorator `classmethod` and also inheriting from the previous one, so they collide. - l10n_es_aeat_sii_oca: l10n_es_pos_sii adds the inheritance on AccountTestInvoicingCommon - l10n_es_intrastat_report: Direct inheritance. The solution is to rename these methods to another name.
Steps to reproduce: - Enable SII in a company with connector with a delay of 48 hours. - Create and validate an invoice. A job is configured for being executed in 48 hours. - Next day, filter "Not sent to SII", and do Action > Send to SII. Result: the pending invoices are requeued and the delay is reapplied, so the invoices will be sent in 48 hours from that moment. Doing this indefinitely, the invoices will never be sent! Although it's a weird behavior, let's avoid it not requeuing the invoices with pending jobs. For this, a little refactor in the code has been done, not calling _cancel_sii_jobs, but filtering another way, and not removing previous failed jobs, which can be considered the only functional change, and it's not bad IMO. TT50641
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/
Creación de un nuevo modelo en `l10n_es_aeat` llamado *aeat_mixin*, del que heredan *sii.mixin* (ya existente) y un nuevo *verifactu.mixin*. Refactor de *sii.mixin* pasando funcionalidad a *aeat_mixin* Se han renombrado varios campos sii_* a aeat_* ya que serán utilizados por ambos.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/
Following odoo/odoo@fbc7214, this commit puts the new taxes on the corresponding SII maps for being able to send invoices containing them to the AEAT service. TT51016
Similar to OCA#3744 TT51159
…atibilities (hr_expense for example) Steps to reproduce: - Install hr_expense - Create a purchase type journal named Expenses and uncheck the Enable SII field. - Go to Expense > Configuration > Settings and define in Employee Expense Journal the Expenses journal previously created - Create an expense and an expense sheet - Click on the Submit to manager button - Click on the Approve button - Click on the Post journal entries button - The journal entry will be created correctly without any error TT51825
…abled field TT52143
…taxes Odoo screwed up the tax XML-IDs in the middle of the 17.0 lifecycle, introducing an unfolding of the exempt taxes, using existing ones that belongs to the sales intra and extra community taxes. After that, they have renamed the XML-IDs of both taxes to new ones. We need to handle this in 2 ways: - Detect and correct existing installations previous to this taxpocalypse for renaming them. - Change the reference in all places to the new XML-IDs. Besides, we have to add the unfolded exempt taxes in the reports.
AaronHForgeFlow
force-pushed
the
18.0-mig-l10n_es_aeat_sii_oca
branch
2 times, most recently
from
e602f73 to
8f4d5bb
Compare
pedrobaeza
reviewed
Aug 7, 2025
| required="sii_enabled and move_type in ['out_refund','in_refund']" | ||
| invisible="move_type not in ['out_refund','in_refund']" | ||
| /> | ||
| name="thirdparty_number" |
There was a problem hiding this comment.
Todos estos cambios de indentación no parecen correctos. ¿Puedes revisar?
There was a problem hiding this comment.
Lo miro, intencionados no son, quizás sea el pre-commit
There was a problem hiding this comment.
Se había colado un '/>' extra. No entiendo como no petaba 😕
…sources like as journal
When using the not subjected tax for services, the reason stated in the journal was ignored, always putting "ImporteTAIReglasLocalizacion", on contrary than with goods, so let's call the same method to get the reason.
AaronHForgeFlow
force-pushed
the
18.0-mig-l10n_es_aeat_sii_oca
branch
from
8f4d5bb to
8750057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3737
Basic technical review from: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
Depends on: