[18.0][MIG] payment_redsys: Migration to 18.0 #4065

jordi-josc · 2025-03-10T14:40:32Z

No description provided.

* Corregido error en caso de que refence no este informado, al renderizar la plantilla del boton de pago. * Corregido error que no permite pagar por transferencia al instalar el modulo payment_redsys * Añadidas descripciones de los productos de la cesta a la clave 'DS_Merchant_ProductDescription'.

* Make quotation sending optional when a transaction ends without error website_sale module already sends an e-mail with the confirmed order, so it May not be necessary to send another e-mail with the same order unconfirmed. * Add more Redsys frontend languages * Remove options tab

* Send quotation e-mail invoking force_quotation_send() instead of action_quotation_send() + send_mail() * The function send_mail() does not respect the context language so the email is always sent in English. * It's not necessary to create the function send_mail() to sent an email when exists the method force_quotation_send(). * Add detailed error info

…r payment + Default values for urk_KO and url_OK + option to print print sale report. Delete url_ok and url_ko fields + Redondeo de merchant_amount

The discount is shown on the order summary if the current user is a member of sale.group_discount_per_so_line group OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[IMP] payment_redsys: Allow partial payment by percent

Includes to allow show order for unauthenticated users

When we have an order sequence of length six (SO123456), the signature process fails with the following message: Server Error: We are not able to redirect you to the payment form. 'str' object has no attribute 'decode'

Currently translated at 71.6% (48 of 67 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (67 of 67 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (67 of 67 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-payment_redsys/es/

Currently translated at 100.0% (47 of 47 strings) Translation: l10n-spain-13.0/l10n-spain-13.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-payment_redsys/es/

Currently translated at 97.9% (46 of 47 strings) Translation: l10n-spain-13.0/l10n-spain-13.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-payment_redsys/ca/

…jecutar post procesado al recibir el formulario POST de Redsys + Avoid execute method por non Redsys acquirer

TT26443

Currently translated at 100.0% (46 of 46 strings) Translation: l10n-spain-14.0/l10n-spain-14.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-payment_redsys/ca/

…eration to make web.base.url the default if website is not installed

pedrobaeza · 2025-03-10T14:45:52Z

/ocabot migration payment_redsys

payment_redsys/__manifest__.py

pedrobaeza · 2025-03-10T14:47:53Z

payment_redsys/models/payment_provider.py

@@ -42,7 +42,7 @@ def _redsys_get_api_url(self):
        "Terminal", default="1", required_if_provider="redsys"
    )
    redsys_currency = fields.Char(
-        "Currency", default="978", required_if_provider="redsys"
+        "Currency Redsys", default="978", required_if_provider="redsys"


Para que Redsys Currency sea la etiqueta:

Suggested change

"Currency Redsys", default="978", required_if_provider="redsys"

default="978", required_if_provider="redsys"

payment_redsys/tests/test_redsys.py

jordi-josc · 2025-04-02T14:31:10Z

Hola @pedrobaeza. He actualizado el código optimizando cada detalle. Espero tu review.

pedrobaeza · 2025-04-05T18:55:14Z

payment_redsys/__manifest__.py

    "author": "Tecnativa, Odoo Community Association (OCA)",
    "website": "https://github.com/OCA/l10n-spain",
-    "depends": ["payment"],
+    "depends": ["payment", "sale"],


Por qué se añade la dependencia sale?

Porque en el archivo “payment_provider.py” en las lineas 189-195 se usa el modelo de “sale.order”. Si el
modulo de “sale” no esta instalado, no funcionaria.

def _product_description(self, order_ref):
sale_order = self.env["sale.order"].search([("name", "=", order_ref)])
res = ""
if sale_order:
description = "|".join(x.name for x in sale_order.order_line)
res = description[:125]
return res

pedrobaeza · 2025-04-05T18:55:35Z

payment_redsys/data/payment_redsys.xml

@@ -2,12 +2,6 @@
 <!-- Copyright 2016-2017 Tecnativa - Sergio Teruel
     License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl-3). -->
 <odoo noupdate="1">
-    <record id="payment_method_redsys" model="account.payment.method">


Por qué se quita este método y no el de Bizum? No deberían ir los dos de la misma forma?

No, ya que redsys es un “account.payment.method” que no es usado para pagar, sino para cosas como
contabilidad por ejemplo. Al no verlo necessario, lo que quitado. Si queremos pagar tenemos que usar
“payment.method”.

pedrobaeza · 2025-04-05T18:55:55Z

payment_redsys/i18n/payment_redsys.pot

@@ -1,252 +0,0 @@
-# Translation of Odoo Server.


El archivo .pot no debería desaparecer, si no si acaso actualizarse.

Ahora ya te lo he subido, error mio quitarlo.

pedrobaeza · 2025-04-05T18:56:13Z

payment_redsys/models/account_payment_method.py

-    _inherit = "account.payment.method"
-
-    @api.model
-    def _get_payment_method_information(self):


Esto por qué se elimina?

Se elimina ya que hay un metodo en odoo standard que hace lo mismo:
https://github.com/odoo/odoo/blob/18.0/addons/account_payment/models/account_payment_method.py#L11

antelo · 2025-04-07T17:55:36Z

Hola, que tal vais con esta migración? os puedo echar una mano?

jordi-josc · 2025-04-11T08:17:54Z

Hola @antelo, por ahora voy bien, ¡si necesito ayuda te aviso!

pedrobaeza · 2025-04-11T13:47:43Z

payment_redsys/models/payment_provider.py

+        return self._redsys_get_api_url()
+
+    def _product_description(self, order_ref):
+        sale_order = self.env["sale.order"].search([("name", "=", order_ref)])


Esto no debería estar en este módulo. Si acaso, en un módulo de extensión, u obtenido de otro lado. @sergio-teruel por qué añadiste esto directamente rompiendo las dependencias?

acysos · 2025-06-04T22:23:03Z

/ocabot migration l10n_es_vat_book

OCA-git-bot · 2025-06-04T22:23:11Z

The migration issue (#3754) has not been updated to reference the current pull request because a previous pull request (#4098) is not closed.
Perhaps you should check that there is no duplicate work.
CC @IsabelAForgeFlow

jordi-josc · 2025-07-23T08:58:45Z

Hola @pedrobaeza ¿Este módulo como ha quedado?

pedrobaeza · 2025-07-23T10:19:19Z

@jordi-josc debes hacer rebase y resolver los conflictos, y luego, hay que eliminar la parte que mira a sale.order, porque el módulo no debe depender de sale.

pedrobaeza · 2025-07-23T10:19:30Z

/ocabot migration payment_redsys

sergio-teruel and others added 30 commits March 10, 2025 12:54

[ADD] Nuevo modulo para pagos con tajeta (sermepa-redsys)

cd26175

[DEL] No crear un pago redsys por defecto al instalar

def1839

[FIX] payment_redsys: New module

2f09c6f

[IMP] payment_redsys: Migracion a HMAC SHA-256

90dbe25

[FIX] payment_redsys: Renaming class name yields unwanted side effect.

ee1ce1b

[IMP] payment_redsys: Change payment logo

30cd487

[IMP] payment_redsys: Change card icon in checkout process.

79cf73b

[IMP+FIX] payment_redsys: Logo tarjetas + Show order information afte…

829e911

…r payment + Default values for urk_KO and url_OK + option to print print sale report. Delete url_ok and url_ko fields + Redondeo de merchant_amount

[IMP][8.0] payment_redsys: Pagar un porcentaje del pedido (OCA#362)

c6b25b2

[IMP] payment_redsys: Allow partial payment by percent

[MIG] payment_redsys: Migration to v9

4aa57b1

Includes to allow show order for unauthenticated users

[MIG] payment_redsys: Migrated to 10.0

70fe0e5

[11.0][MIG] payment_redsys: Migration

f9b0cfc

[chg] Dependency from abandoned pycrypto to pycryptodome

44e84fd

[FIX] payment_redsys: Fix signature

494224b

When we have an order sequence of length six (SO123456), the signature process fails with the following message: Server Error: We are not able to redirect you to the payment form. 'str' object has no attribute 'decode'

[IMP] payment_redsys: README by fragments

7aadac1

[12.0][MIG] payment_redsys: Better test coverage

f112f9c

[IMP] payment_redsys: Better status code check

ea9a3d8

[FIX] payment_redsys: Process order after gateway payment successful

807753d

[IMP] account_multicompany_easy_creation: black, isort, prettier

d5d6a33

[MIG] payment_redsys: Migration to v13.0

cd21f65

Translated using Weblate (Spanish)

9a62cea

Currently translated at 100.0% (47 of 47 strings) Translation: l10n-spain-13.0/l10n-spain-13.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-payment_redsys/es/

Translated using Weblate (Catalan)

ffd7a39

Currently translated at 97.9% (46 of 47 strings) Translation: l10n-spain-13.0/l10n-spain-13.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-payment_redsys/ca/

[FIX+IMP] payment_redsys: Set Merchant titular as billing partner + E…

a88491a

…jecutar post procesado al recibir el formulario POST de Redsys + Avoid execute method por non Redsys acquirer

[MIG] payment_redsys: Migration to 14.0

01ccc7f

TT26443

Translated using Weblate (Catalan)

f29f95f

Currently translated at 100.0% (46 of 46 strings) Translation: l10n-spain-14.0/l10n-spain-14.0-payment_redsys Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-payment_redsys/ca/

oca-ci and others added 4 commits March 10, 2025 12:54

[UPD] Update payment_redsys.pot

2ecf616

[BOT] post-merge updates

d614ab4

[IMP] payment_redsys: remove website_sale dependency, and fix url gen…

ebc617b

…eration to make web.base.url the default if website is not installed

[BOT] post-merge updates

9c1c54a

jordi-josc mentioned this pull request Mar 10, 2025

[IMP] payment_redsys: Updating the module to the version 18 #4041

Closed

pedrobaeza changed the title ~~18.0 mig payment redsys~~ [18.0][MIG] payment_redsys: Migration to 18.0 Mar 10, 2025

OCA-git-bot added this to the 18.0 milestone Mar 10, 2025

OCA-git-bot mentioned this pull request Mar 10, 2025

Migration to version 18.0 #3754

Open

40 tasks

pedrobaeza reviewed Mar 10, 2025

View reviewed changes

jordi-josc force-pushed the 18.0-mig-payment_redsys branch from 1b37768 to 1672d96 Compare March 11, 2025 10:17

jordi-josc requested a review from pedrobaeza March 11, 2025 10:21

jordi-josc force-pushed the 18.0-mig-payment_redsys branch 6 times, most recently from 8ddabad to 7762dd1 Compare April 2, 2025 14:26

pedrobaeza reviewed Apr 5, 2025

View reviewed changes

[MIG] payment_redsys: Migration to 18.0

aeaeec6

jordi-josc force-pushed the 18.0-mig-payment_redsys branch from 7762dd1 to aeaeec6 Compare April 11, 2025 08:18

pedrobaeza reviewed Apr 11, 2025

View reviewed changes

	"Currency Redsys", default="978", required_if_provider="redsys"
	default="978", required_if_provider="redsys"

Uh oh!

[18.0][MIG] payment_redsys: Migration to 18.0 #4065

Are you sure you want to change the base?

[18.0][MIG] payment_redsys: Migration to 18.0 #4065

Uh oh!

Conversation

jordi-josc commented Mar 10, 2025

Uh oh!

pedrobaeza commented Mar 10, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jordi-josc commented Apr 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antelo commented Apr 7, 2025

Uh oh!

jordi-josc commented Apr 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acysos commented Jun 4, 2025

Uh oh!

OCA-git-bot commented Jun 4, 2025

Uh oh!

jordi-josc commented Jul 23, 2025

Uh oh!

pedrobaeza commented Jul 23, 2025

Uh oh!

pedrobaeza commented Jul 23, 2025

Uh oh!

Uh oh!