Skip to content

[17.0][IMP] l10n_es_igic: tax names changed #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

Christian-RB
Copy link
Contributor

@Christian-RB Christian-RB commented Mar 13, 2025

Hemos detectado algunos problemas intentando asignar el plan contable de canarias a algunos clientes que ya presentaban un plan contable de península. Por lo que hemos podido comprobar, debido a que los impuestos de península y canarias convivien en la misma contabilidad (al menos en esta versión), al ejecutar el account chart update o bien detecta constantemente el mismo impuesto para xml ids distintos o bien nos da un error de que no pueden existir múltiples impuestos con el mismo name.
Por esto considero que lo mejor sería cambiar los nombres de los impuestos evitando así esta problemática.
@BinhexTeam

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A priori me parece bien

@pedrobaeza pedrobaeza added this to the 17.0 milestone Mar 13, 2025
@pedrobaeza pedrobaeza requested a review from etobella March 13, 2025 19:22
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

@etobella te parece bien?

@Christian-RB Christian-RB force-pushed the 17.0-imp-l10n_es_igic branch from 4b669dc to f563a95 Compare March 19, 2025 12:23
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-4076-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ded8c86 into OCA:17.0 Mar 19, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 21b98c6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants