Skip to content

[17.0][IMP] l10n_es_aeat: Manage AEAT Real Estates #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][IMP] l10n_es_aeat: Manage AEAT Real Estates #4221

wants to merge 1 commit into from

Conversation

carlossainznetkia
Copy link

Se añade el modelo l10n_es_aeat_real_estate para gestionar los inmuebles

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

EmilioPascual
EmilioPascual suggested changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias por el aporte @carlossainznetkia.

Creo que este pr es una mejora y no un fix.

@carlossainznetkia
Copy link
Author

Muchas gracias por el aporte @carlossainznetkia.

Creo que este pr es una mejora y no un fix.

Muchas gracias por la revisión @EmilioPascual !

Hemos corregido todas tus indicaciones.

@carlossainznetkia carlossainznetkia force-pushed the 17.0-IMP-l10n_es_aeat branch 3 times, most recently from 46ce460 to 9259692 Compare June 5, 2025 17:49
EmilioPascual
EmilioPascual suggested changes Jun 6, 2025
View reviewed changes
This was referenced Jun 9, 2025
Closed
Open
@carlossainznetkia carlossainznetkia changed the title [17.0][FIX] l10n_es_aeat: Manage AEAT Real Estates [17.0][IMP] l10n_es_aeat: Manage AEAT Real Estates Jun 10, 2025
EmilioPascual
EmilioPascual suggested changes Jun 17, 2025
View reviewed changes
@carlossainznetkia carlossainznetkia force-pushed the 17.0-IMP-l10n_es_aeat branch 3 times, most recently from 7a9f9e5 to 6032771 Compare July 15, 2025 11:14
EmilioPascual
EmilioPascual suggested changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahora ya lo veo bien, en este pr todo lo referente a los inmuebles y en el otro sólo cosas del 180. Sólo una pequeña cosa a cambiar.
@carlossainznetkia gracias por tu trabajo.

ArantxaSudon
ArantxaSudon approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@ArantxaSudon ArantxaSudon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisado funcionalmente

Para crear uno nuevo son obligatorios los campos: Empresa, Calle, Ciudad y Código postal. Tal vez debería ser obligatorio el NIF y la referencia catastral ya que serán necesarios al declarar el 180

@pedrobaeza
Copy link
Member

Creo que de primeras es mejor no limitarlo, ya que esa información puedes no tenerla en el momento de la factura, y luego solo en el 180 ya introducirlo o dar error si no existe.

rafaelbn
rafaelbn approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias. Revisado funcional en runbot 👍🏼

@moduon MT-10494

@carlossainznetkia
Copy link
Author

Realizado último cambio e incrementado el coverage.

Gracias a todos por los reviews!

EmilioPascual
EmilioPascual approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenomenal @carlossainznetkia. Gracias por la mejora y los cambios.

¿@pedrobaeza puedes revisarlo por favor? Creo que es una funcionalidad importante que se perdió con el tiempo. Muchas gracias.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@EmilioPascual EmilioPascual EmilioPascual approved these changes

@ArantxaSudon ArantxaSudon ArantxaSudon approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carlossainznetkia @OCA-git-bot @pedrobaeza @rafaelbn @EmilioPascual @ArantxaSudon