Skip to content

[18.0][MIG] l10n_es_facturae #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Aug 5, 2025
Merged

Conversation

etobella
Copy link
Member

@etobella etobella commented Aug 5, 2025

He eliminado los t-if="False" ya que no son necesarios por el cambio en la limpieza del informe.

Se han aplicado algunos cambios en los tests para que se ejecuten todos correctamente.

OCA-git-bot and others added 30 commits August 5, 2025 09:27
Signed-off-by pedrobaeza
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_facturae
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_facturae/
TT55080

[IMP] l10n_es_facturae: Importe retención garantía modificable

Se define el campo facturae_withheld_amount readonly=False para permitir modificarlo
para que se pueda ajustar manualmente por ejemplo por el redondeo.

TT55080

[IMP] l10n_es_facturae: Restar el importe de retención de garantía del total

Relacionado con https://github.com/OCA/l10n-spain/blob/abf6a4bb0ee52305649f07036568f52c220f1c84/l10n_es_facturae/data/Facturaev3_2_2.xsd#L884

TT55080
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_facturae
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_facturae/
Fixes an issue where attachments were not decoded to UTF-8, making them unreadable.
…cturae attachments

Facturae attachments were double Base64 encoded, requiring two decodings to be accessible.
…taxes

Odoo screwed up the tax XML-IDs in the middle of the 17.0 lifecycle,
introducing an unfolding of the exempt taxes, using existing ones
that belongs to the sales intra and extra community taxes.

After that, they have renamed the XML-IDs of both taxes to new ones.

We need to handle this in 2 ways:

- Detect and correct existing installations previous to this
  taxpocalypse for renaming them.
- Change the reference in all places to the new XML-IDs.

Besides, we have to add the unfolded exempt taxes in the reports.
It's a leftover of previous versions where it was used.
… the FacturaE process. If the user does not provide it, document generation fails and module crashes.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_facturae
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_facturae/
@etobella
Copy link
Member Author

etobella commented Aug 5, 2025

/ocabot migration l10n_es_facturae

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 5, 2025
@OCA-git-bot
Copy link
Contributor

The migration issue (#3754) has not been updated to reference the current pull request because a previous pull request (#4175) is not closed.
Perhaps you should check that there is no duplicate work.
CC @AaronHForgeFlow

@etobella etobella force-pushed the 18.0-mig-l10n_es_facturae branch from cb9b981 to 5cca96a Compare August 5, 2025 08:20
@etobella
Copy link
Member Author

etobella commented Aug 5, 2025

/ocabot migration l10n_es_facturae

@OCA-git-bot OCA-git-bot mentioned this pull request Aug 5, 2025
40 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La dependencia de l10n_es_aeat es solo para los tests?

"author": "ASR-OSS, "
"FactorLibre, "
"Tecon, "
"Comunitea, "
"Tecnativa, "
"Creu Blanca, "
"Dixmit, "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que para esta versión habría que commutar Creu Blanca por Dixmit en lugar de añadir ambos, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bueno, técnicamente estaría bien revisar bien los autores originales y revisar si tiene sentido mantenerlos a todos, pero por mi no hay problema.

@@ -20,7 +20,7 @@
)


class CommonTestBase(TestL10nEsAeatCertificateBase, TestL10nEsAeatModBase):
class CommonTest(TestL10nEsAeatCertificateBase, TestL10nEsAeatModBase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tal vez habría que depender directamente del AccountInvoicingTestCommon o algo así y no crear a mano cuentas contables.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto probablemente viene dado por la configuración que existía en v11 o v12 y que se ha ido heredando.

Miro a ver si podemos quitarnos este problema.

@etobella etobella force-pushed the 18.0-mig-l10n_es_facturae branch from 5cca96a to 733d0c0 Compare August 5, 2025 10:19
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-4340-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7d75b23 into OCA:18.0 Aug 5, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a46ecf3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants