This repository has been archived by the owner on May 16, 2024. It is now read-only.
[FIX] test_pylint: Fix empty paths #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
@lepistone |
|
👍 |
|
Fixes #240. I merge. |
pedrobaeza
added a commit
that referenced
this pull request
Aug 30, 2015
[FIX] test_pylint: Fix empty paths
| extra_params=extra_params) | ||
| count_fails = get_count_fails(stats) | ||
| except ValueError: | ||
| count_fails = -1 |
There was a problem hiding this comment.
this has to be count_fails = 0.
See https://travis-ci.org/OCA/contract/jobs/77930562
There was a problem hiding this comment.
======== Testing test_pylint ========
pylint expected errors 0, found -1!
There was a problem hiding this comment.
I have amended the commit to put 0. Rerun Travis.
There was a problem hiding this comment.
It's not that simple. I have to reverted again and check carefully
There was a problem hiding this comment.
Let me try to fix it
There was a problem hiding this comment.
FYI I tested with travis2docker with contract/8.0
pedrobaeza
added a commit
that referenced
this pull request
Aug 30, 2015
[FIX] test_pylint: Fix empty paths
pedrobaeza
added a commit
that referenced
this pull request
Aug 30, 2015
[FIX] test_pylint: Fix empty paths
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to avoid next issue:
OCA/runbot-addons#53