Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

[REF] pylint_pr.cfg: Deprecated unittest2 for new PR w/o affect build status #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moylop260
Copy link
Contributor

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this can be still legitimate for Odoo <=v10, so I'm not sure if this is the solution.

@moylop260
Copy link
Contributor Author

moylop260 commented Jul 11, 2017

The unittest2 package was removed from odoo requirements.txt since 9.0 version.
Maybe we are using this package without a real justification.

NOTE: I have created this PR because your comment #460 (comment) so I don't know what is your proposal here

@moylop260
Copy link
Contributor Author

Maybe @guewen could help us to resolve this doubt.

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unittest2 is a backport of Python 2.7 features to 2.4-2.6. IMO those versions are ancient and anyone using them should update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants