[16.0][FIX] maintenance_timesheet: Define the correct rule to show only what is related to maintenance_request_id

[victoralmau]

Define the correct rule to show only what is related to maintenance_request_id

Locked by:

• project_timesheet_time_control: [16.0][FIX] project_timesheet_time_control: Define the appropriate date if it is a str project#1547

Please @pedrobaeza and @pilarvargas-tecnativa can you review it?

@Tecnativa TT56859

[pedrobaeza]

The change is not correct as is. I don't say it was correct, but the solution isn't to change = to !=. That way, you give access to all the timesheets related to maintenance. Maybe you need to just remove that part?

[victoralmau]

Right now, I don't know exactly what is not being taken into account.

Before
With the existing rule, you had access to everything that was not related to maintenance_request (maintenance_request=False). That is definitely a total mistake (or at least it is for me).

After
The existing rule is intended to be related only to maintenance requests, which is why the rule only takes into account what is related to maintenance requests (maintenance_request!=False) and what is “linked to its user”.

So what is the appropriate rule?

[dalonsod]

The change is not correct as is. I don't say it was correct, but the solution isn't to change = to !=. That way, you give access to all the timesheets related to maintenance. Maybe you need to just remove that part?

Sure, the original code seems to be incorrect, you're right 😕

The new one already makes more changes than moving = to !=, it also removes an extra OR, so it's not only, for the timesheet, required belonging to a maintenance request, but following it as well. I see it now right.

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-501-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at a131e60. Thanks a lot for contributing to OCA. ❤️