Skip to content

[13.0][MIG] mgmtsystem_manual: Migration to 13.0 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 22, 2019
Merged

[13.0][MIG] mgmtsystem_manual: Migration to 13.0 #269

merged 16 commits into from
Nov 22, 2019

Conversation

ernestotejeda
Copy link
Member

@ernestotejeda ernestotejeda commented Nov 8, 2019 •
edited by pedrobaeza
Loading

Depends on:

As this module depends on #268 I have included here the commits of that PR so it can be functionally tested.

Cc @Tecnativa TT20482

@oca-clabot
Copy link

Hey @ernestotejeda, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@dreispt
Copy link
Member

dreispt commented Nov 8, 2019

Why is the build green, if the dependencies are not ready?

@pedrobaeza
Copy link
Member

Because the dependency is included here until it's merged, and then the PR is rebased.

@ernestotejeda ernestotejeda force-pushed the 13.0-mig-mgmtsystem_manual branch 2 times, most recently from 4f4ca78 to b24ba2b Compare November 8, 2019 22:40
@ernestotejeda
Copy link
Member Author

As #268 is merged i rebased and cleaned up the commit history a bit

@ernestotejeda ernestotejeda force-pushed the 13.0-mig-mgmtsystem_manual branch from b24ba2b to 80e1d62 Compare November 12, 2019 16:10
@ernestotejeda ernestotejeda reopened this Nov 12, 2019
Tardo
Tardo reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza pedrobaeza added this to the 13.0 milestone Nov 13, 2019
@pedrobaeza
Copy link
Member

@Tardo why don't you approve it instead of putting a comment?

pedrobaeza
pedrobaeza approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this can't merged until document_page is merged and oca_dependencies.txt must be removed.

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 13, 2019
Open
21 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

Please switch the oca_dependencies.txt file now that the dependency is merged

@ernestotejeda ernestotejeda force-pushed the 13.0-mig-mgmtsystem_manual branch from 80e1d62 to 28fb128 Compare November 15, 2019 17:06
@ernestotejeda
Copy link
Member Author

oca_dependencies.txt file updated

chienandalu
chienandalu suggested changes Nov 20, 2019
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ernestotejeda you should rebase as there are merge conflicts now

ThomasBinsfeld and others added 8 commits November 22, 2019 08:58
@ThomasBinsfeld @ernestotejeda
[IMP] mgmtsystem: document_page_approval as option
8f410a2
@oca-transbot @ernestotejeda
OCA Transbot updated translations from Transifex
31e4011
@jalzaga @ernestotejeda
[MIG] mgmtsystem_manual: Migration to 11.0
a747e8d
@primes2h @ernestotejeda
Added translation using Weblate (Italian)
c7d071b 
Translated using Weblate (Italian)

Currently translated at 100.0% (4 of 4 strings)

Translation: management-system-11.0/management-system-11.0-mgmtsystem_manual
Translate-URL: https://translation.odoo-community.org/projects/management-system-11-0/management-system-11-0-mgmtsystem_manual/it/
@gurneyalex @ernestotejeda
[MIG] migration to 12.0
7604d9a
@ernestotejeda
Translated using Weblate (Portuguese (Brazil))
6e4092b 
Currently translated at 100.0% (5 of 5 strings)

Translation: management-system-12.0/management-system-12.0-mgmtsystem_manual
Translate-URL: https://translation.odoo-community.org/projects/management-system-12-0/management-system-12-0-mgmtsystem_manual/pt_BR/
@awesome-manuel @ernestotejeda
Translated using Weblate (German)
73c0d7d 
Currently translated at 100.0% (5 of 5 strings)

Translation: management-system-12.0/management-system-12.0-mgmtsystem_manual
Translate-URL: https://translation.odoo-community.org/projects/management-system-12-0/management-system-12-0-mgmtsystem_manual/de/
@ernestotejeda
[IMP] mgmtsystem_manual: black, isort
ebf5501
@ernestotejeda ernestotejeda force-pushed the 13.0-mig-mgmtsystem_manual branch from 28fb128 to 0c21307 Compare November 22, 2019 14:08
@ernestotejeda ernestotejeda force-pushed the 13.0-mig-mgmtsystem_manual branch from 0c21307 to 195bc0e Compare November 22, 2019 15:06
@dreispt
Copy link
Member

dreispt commented Nov 22, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-269-by-dreispt-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 22, 2019
@OCA-git-bot
Merge PR #269 into 13.0
7eabfc6 
Signed-off-by dreispt
@OCA-git-bot OCA-git-bot merged commit 195bc0e into OCA:13.0 Nov 22, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a28b0b1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu requested changes

@Tardo Tardo Tardo approved these changes

@dreispt dreispt dreispt approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉 work in progress
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.