Skip to content

[13.0][MIG] document_page_work_instruction: Migration to 13.0 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 17, 2019
Merged

[13.0][MIG] document_page_work_instruction: Migration to 13.0 #272

merged 17 commits into from
Nov 17, 2019

Conversation

ernestotejeda
Copy link
Member

Cc @Tecnativa TT20478

naousse and others added 16 commits November 12, 2019 12:54
@naousse @ernestotejeda
Migraion of document_page_work_instructions to Odoo 9.0
fc6781d
@oca-transbot @ernestotejeda
OCA Transbot updated translations from Transifex
56e7f3e
@sbidoul @ernestotejeda
[FIX] remove en.po that was erroneously created by transbot
0e08bed
@pedrobaeza @ernestotejeda
[MIG] Make modules uninstallable
51e8d72
@pedrobaeza @ernestotejeda
[MIG] Rename manifest files
109616d
@eugen-don @ernestotejeda
MIG document_page_work_instructions to V. 10.0
408641f 
MIG document_page_work_instructions to V. 10.0
@ThomasBinsfeld @ernestotejeda
[IMP] mgmtsystem: document_page_approval as option
a14bf5b
@oca-transbot @ernestotejeda
OCA Transbot updated translations from Transifex
5883bb0
@jalzaga @ernestotejeda
[MIG] document_page_work_instruction: Migration to 11.0
464aac1
@oca-travis @ernestotejeda
[UPD] Update document_page_work_instruction.pot
9f0b104
@primes2h @ernestotejeda
Added translation using Weblate (Italian)
25e7b5b 
Translated using Weblate (Italian)

Currently translated at 100.0% (2 of 2 strings)

Translation: management-system-11.0/management-system-11.0-document_page_work_instruction
Translate-URL: https://translation.odoo-community.org/projects/management-system-11-0/management-system-11-0-document_page_work_instruction/it/
@ernestotejeda
[MIG] document_page_work_instruction: migrate to v12
0972eeb
@oca-travis @ernestotejeda
[UPD] Update document_page_work_instruction.pot
e860e9d
@ernestotejeda
[FIX] Fixing pylint errors
95fce3b 
Modules: document_page_quality_manual, document_page_work_instruction,
mgmtsystem_action
@OCA-git-bot @ernestotejeda
[UPD] README.rst
d2dd77b
@ernestotejeda
[IMP] document_page_work_instruction: black, isort
4cc4921
Tardo
Tardo approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

For me, the diff table can be improved using 100% of the width...

** Update oca_dependencies when ready

@ernestotejeda
Copy link
Member Author

For me, the diff table can be improved using 100% of the width...

I think it is a bit difficult to have the table width 100% and at the sam time to have the text wrapped.
What happens is that by default the python library that is used for the differences by default does not wrap the text and also the texts that are being taken to obtain the differences are html text and also those texts don't have spaces, then each paragraph (<p>) for example, although you see it with space, spaces are replaced by &nbsp; for the comparision. Maybe it needs more thinking and more time.

@ernestotejeda ernestotejeda force-pushed the 13.0-mig-document_page_work_instruction branch from a27b7a2 to 30f1f10 Compare November 15, 2019 17:10
@ernestotejeda
Copy link
Member Author

oca_dependencies.txt file updated

@pedrobaeza pedrobaeza added this to the 13.0 milestone Nov 17, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 17, 2019
Open
21 tasks
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-272-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 17, 2019
@OCA-git-bot
Merge PR #272 into 13.0
76bfbed 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-272-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 17, 2019
@OCA-git-bot
Merge PR #272 into 13.0
bb69c65 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 30f1f10 into OCA:13.0 Nov 17, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 61356f7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.