[13.0][MIG] mgmtsystem_nonconformity: Migration to 13.0 #275

ernestotejeda · 2019-11-27T04:24:02Z

Cc @Tecnativa TT20483

…ons. [IMP] [#9439] Added the system reference field to the model and the views. [IMP] efficiency -> effectiveness [FIX] group_mgmtsystem_manager XML ID [IMP] mgmtsystem_kpi [FIX] Group references. Reported by michaelgiesbrecht on the forum. [ADD] Icons [IMP] Views [ADD] NC : Workflow, actions_ids [ADD] Action : Review fields [REM] NC : Effectiveness fields [IMP] Use workflow and improve filters. [FIX] button_cancel invisible and system_id readonly on closed state. [FIX] Can't group by procedure_ids

* ADD workflow reset option. ADD workflow transition from Open to Pending. CHG config tables are translatable. ADD pt translation. * CHG process sequence logic. ADD approval records for each stage. * CHG: finetunning user interface * [ADD] Actions link back to NCs. [CHG] Actions UI improvements. [DEL] Action review not necessary. [ADD] NC on_change department fills automatically responsibles. * ADD: communication & history tab for NCs * ADD: keep history record for state changes and approvals pt translations

…al module + qualification fields moved from feedback to NC; actions can be linked to projects

CHG: NC analysis is required at state 'p' CHG: added parent to group NC Causes; removed NC Category ADD: state 'analysis', between 'draft' and 'pending' CHG: NC flow logic organized according to the typical sequence CHG: small fixes and finetuning CHG: marking Apps, security review, translation pt, finetuning

* licenses and dependencies * Update hooks with addons modules from v7 * Permissions on files * Add origins and causes data

* CHG Renamed 'feedback' to 'claim', see explanation in __openerp__.py * CHG pt_pt translation * FIX Fixing fields read-only flags based on state * CHG Improving action <-> NC relationship (wip) * [FIX] fixes from review comments * [FIX] missing context; instanciation of models * [CHG] AGPL license; set verion to 1.0 * [CHG] Selections use words instead of letters; fixed AGPL-3 reference * [FIX] .py files licenses to AGPL

* NameError: global name 'context' is not defined when resetting a NC * Skeleton for migration script * openupgrade analysis

[ADD] Added migration scripts for 0.1 --> 1.0 in the modules that needed it. mgmtsystem_nonconformity: * o --> open c --> done state change. * Migrating action relations to a many2many table. * Concatening action comments in a single field mgmtsystem_audit and mgmtsystem_review: * o --> open c --> done state change. [FIX] I had accidentally broken the nonconformity/action migration shortly before commit. [FIX] Fixed "Unknown field state for domain" errors. In 7.0, it's necessary, in a view, to have the field present in a view in order to use it in a domain. I added an invisible "state" field in relevant views to fix the errors. [CHG] Adjusted mgmgsystem_nonconformity to OpenERP 7.0. Like with mgmtsystem_action, the problem comes from changes made in OpenERP's messaging system. [FIX] Broken reference to wiki's group_id. In OpenERP 7, document_page had a parent_id instead of wiki's group_id. I've fixed the broken references that we had left in nonconformity and audit. [FIX] Fixed wrongful merge. The merge of nc-extend-7.0 was incorrect. It wrongly used the 6.1 version of mgmtsystem_audit.xml and mgmtsystem_nonconformity/mgmtsystem_nonconformity.xml. Fixed this. [CHG] Updated statusbar/buttons's layout to conform to OpenERP 7.0 style. Instead of a group at the bottom of the form, it's now a <header> tag at the top. Changed Actions, Audit, Nonconformity and Review.

…ail.thread usage of notification

"osv" was mistakenly removed from imports in nc-extend.

…with orm.except_orm()+ Fixed calls to action.case_open() which were made with explicit (cr, uid, id) args. Now, these methods' arguments are implicitly set.

… replaced message history with chatter widget

* [FIX] Remaining group_id * [FIX] Update domain * [UPD] POT files * [IMP] Add company_id and its default value * [IMP] Add company_id in views * [ADD] mgmtsystem_*_security.xml files

* Added autosubscription for Responsible user, Manager and Top manager to follow list of OpenChatter * Autoadding the nonconformity author. * Exception when closing NC that has non closed actions. * Added state 'cancelled' and check for immediate actions.

* Improvement to NC chatter state change messages. * Buttons that change state backwards (towards draft) are no longer highlighted. * Prefix overwriten for Nonconformity * Fix to integrity check error * revert unessessary_inherit to crm.claim * [FIX] Fix PEP8 errors after running 'flake8 . --ignore E501,F401' * [7.0.1.0 Migration scirpts] Added mgmtsystem_action. Made mgmtsystem_nonconformity system more robust. * [FIX] Migration scripts no longer fully dependent on openupgrade * [FIX] Bug #1267840 add values parametter to message_auto_subscribe * Removed redundant import from openupgrade

Updated module as installable and removed depdencie on base_status See the base_status module is apparently gone so we have to work without it. https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-remove-base_status-tde/+merge/179887 Small fix to use stage_id.name instead of state State doesn't exist anymore Use stage_id for actions Add support for settled, rejected instead of done/canceled... quite ugly Separated python in each model file Added missing methodcase_close_send_note for workflows Updated model severity to V8 Port cause model to v8 Fix flake8 error Fix small error in `cause` and upgraded `origin` to v8 Splitted xml views into 5 different xml files Moved icon.png to static/description Added tests and updated cause to v8 Added test origin and changed name of test class for cause Removed severity redefined here Added tests for create nonconformity Ported fields to v8 Fix indent block Removed ID and removed named lambdas Simplify the name_get method Get exceptions without importing orm Removed size Simplified name_get and removed id Replace try except by self.assertRaise Added group in forms Reformat xml files removed tabs/space mix and 2 space indent Fix tests Added left and right to cause and origin Add ondelete to parent_id Fix tests Improved name_get method and full coverage or origin/cause Added workflow test Added missing copyrights Fix flake errors Fix more flake errors Some actions can only be done once actions, analysis Fix even more flakes errors Test reset button Added missing fields (used in demo data) Test state nonconformity name Remove states as we are using stages on actions... It would make more sense to add a property to stages that mark some stages as ending stages instead of checking by names. Use stage is ending and is starting instead of by name Test analysis instead of evaluation Fix flake8 errors Added base security Security rule in wrong project

* Move datas to their own folders * Cleanup Nonconformity * Use track and mail message subtypes instead of overriding functions * Remove unused functions * Cleanup and full use of v8 and track features * Use a python context which does rollback * Fix pep8 * Full test coverage of module

…d es translation.

* Improving test coverage * Fixing flake 8 error * Fixing test error * Remove unnecessary code

* adding drag and drop to kanban view * Fixing flake 8 error * Fixing tests errors * add mgmtsystem_nonconformity_state access rule * removing unused code * Improving form and test

* Remove forced workflow logic * Add kanban state * Fix report state field * Nonconformity view must load state data * Adjust tests and make them pass * Add kanban state (can be used for approvals) * Fix duplicate stage/state tracking * Fix report menu * Add validation on close, requiring evaluation comment * Replace age by days since last update * Fix reports * Reset Kanban State when changing Stages * Prefer using the standard user_id field * Properly implement the NC closing date * Require action plan review for In Progress; Open Actions when In Progress * Rename Pending Approval to Action Plan

import translator _

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 95.0% (114 of 120 strings) Translation: management-system-11.0/management-system-11.0-mgmtsystem_nonconformity Translate-URL: https://translation.odoo-community.org/projects/management-system-11-0/management-system-11-0-mgmtsystem_nonconformity/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: management-system-12.0/management-system-12.0-mgmtsystem_nonconformity Translate-URL: https://translation.odoo-community.org/projects/management-system-12-0/management-system-12-0-mgmtsystem_nonconformity/

[ADD] mgmtsystem_nonconformity: Add activities to nonconformity Add the activities to the model "nonconformity"

Currently translated at 100.0% (120 of 120 strings) Translation: management-system-12.0/management-system-12.0-mgmtsystem_nonconformity Translate-URL: https://translation.odoo-community.org/projects/management-system-12-0/management-system-12-0-mgmtsystem_nonconformity/pt_BR/

Without decorator, you receive a cursor, not an environment

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: management-system-12.0/management-system-12.0-mgmtsystem_nonconformity Translate-URL: https://translation.odoo-community.org/projects/management-system-12-0/management-system-12-0-mgmtsystem_nonconformity/

Currently translated at 100.0% (147 of 147 strings) Translation: management-system-12.0/management-system-12.0-mgmtsystem_nonconformity Translate-URL: https://translation.odoo-community.org/projects/management-system-12-0/management-system-12-0-mgmtsystem_nonconformity/pt_BR/

oca-clabot · 2019-11-27T04:24:04Z

Hey @ernestotejeda, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Glen Sojo [email protected] (no github login found)
Maxime Chambreuil [email protected] (no github login found)
Sandy Carter [email protected] (no github login found)
erp_user xoe user erp_user@webtec-dev (no github login found)
Glen Dromgoole [email protected] (no github login found)
Launchpad Translations on behalf of openerp-commiter (no github login found)

Appreciation of efforts,
OCA CLAbot

mgmtsystem_nonconformity/models/mgmtsystem_nonconformity.py

Tardo · 2019-11-27T14:04:40Z

mgmtsystem_nonconformity/models/mgmtsystem_nonconformity.py

+    def _elapsed_days(self, dt1_text, dt2_text):
+        res = 0
+        if dt1_text and dt2_text:
+            dt1 = fields.Datetime.from_string(dt1_text)


Be carefully... since 12.0 Odoo uses native python datetime (not strings)

mgmtsystem_nonconformity/models/mgmtsystem_nonconformity.py

mgmtsystem_nonconformity/models/mgmtsystem_nonconformity_cause.py

Tardo · 2019-11-27T15:39:49Z

mgmtsystem_nonconformity/models/mgmtsystem_nonconformity_origin.py

+    def name_get(self):
+        res = []
+        for obj in self:
+            name = obj.name


The same as in the other case

Tardo · 2019-11-27T15:49:39Z

mgmtsystem_nonconformity/tests/__init__.py

@@ -0,0 +1,23 @@
+##############################################################################


Use a short license comment

Tardo · 2019-11-27T15:51:14Z

mgmtsystem_nonconformity/tests/test_nonconformity.py

+
+class TestModelNonConformity(common.TransactionCase):
+    def setUp(self):
+        super(TestModelNonConformity, self).setUp()


Suggested change

super(TestModelNonConformity, self).setUp()

super().setUp()

Tardo · 2019-11-27T15:53:32Z

mgmtsystem_nonconformity/views/mgmtsystem_nonconformity.xml

+          <filter name="groupby_system" string="System" icon="gtk-execute" context="{'group_by':'system_id'}"/>
+          <filter name="groupby_partner" string="Partner" icon="terp-personal+" domain="[]" context="{'group_by':'partner_id'}"/>
+          <filter name="groupby_procedure" string="Procedure" icon="terp-stock_symbol-selection" context="{'group_by':'procedure_ids'}"/>
+          <!--


If not used 🔥

chienandalu

Attend @Tardo comments. Otherwise LGTM

ernestotejeda · 2019-11-28T15:24:12Z

Changes done

pedrobaeza · 2019-11-30T12:50:41Z

As comments have been attended:

/ocabot merge

OCA-git-bot · 2019-11-30T12:51:45Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-275-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2019-11-30T13:08:51Z

Congratulations, your PR was merged at 5d36bf5. Thanks a lot for contributing to OCA. ❤️

Maxime Chambreuil and others added 30 commits November 26, 2019 12:39

[IMP] mgmtsystem_nonconformity:: NC Department now added by an option…

fd54d8d

…al module + qualification fields moved from feedback to NC; actions can be linked to projects

[FIX+IMP] mgmtsystem_nonconformity: license, permission and others

1e138cf

* licenses and dependencies * Update hooks with addons modules from v7 * Permissions on files * Add origins and causes data

[FIX+IMP] mgmtsystem_nonconformity: Migration scripts + fix

1da3d82

* NameError: global name 'context' is not defined when resetting a NC * Skeleton for migration script * openupgrade analysis

[FIX[ Migration folder names

5747c7b

[FIX] mgmtsystem_nonconformity: Bug #1162942 + bug #1162946, update m…

3952505

…ail.thread usage of notification

[FIX] Fixed missing import in mgmtsystem_nonconformity.

493f5bc

"osv" was mistakenly removed from imports in nc-extend.

[FIX] No group can create NC

15c5c86

[FIX] mgmtsystem_nonconformity: Replaced deprecated osv.except_osv() …

8542473

…with orm.except_orm()+ Fixed calls to action.case_open() which were made with explicit (cr, uid, id) args. Now, these methods' arguments are implicitly set.

[UPD] translation file

03d18f1

[IMP] mgmtsystem_nonconformity: migrating NC form to v7 sheet style +…

2e77901

… replaced message history with chatter widget

[FIX+IMP] mgmtsystem_nonconformity: Several things + POT

f46f764

* [FIX] Remaining group_id * [FIX] Update domain * [UPD] POT files * [IMP] Add company_id and its default value * [IMP] Add company_id in views * [ADD] mgmtsystem_*_security.xml files

[FIX] PEP8 compliance in audit, action and nonconformity

8e08dcb

[IMP] Documentation in the module description

abcc39d

Launchpad automatic translations update.

15e3e7c

[FIX+IMP] mgmtsystem_nonconformity: Fixed typo in data + Added update…

9ad97b4

…d es translation.

[MIG] Make modules uninstallable

1fabfd8

[IMP+FIX] mgmtsystem_nonconformity: Improvements

b84aaaa

* Improving test coverage * Fixing flake 8 error * Fixing test error * Remove unnecessary code

[IMP] README.rst

2ea4783

[FIX+IMP] mgmtsystem_nonconformity: Several patches

309790d

* adding drag and drop to kanban view * Fixing flake 8 error * Fixing tests errors * add mgmtsystem_nonconformity_state access rule * removing unused code * Improving form and test

Removing pylint and flake8 error using comment

a0f9002

import translator _

oca-transbot and others added 15 commits November 26, 2019 12:39

Update translation files

07d604d

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] mgmgsytem_nonconformity to 12.0

41e50e6

[UPD] README.rst

63f55c4

[UPD] Update mgmtsystem_nonconformity.pot

fff68e2

[UPD] README.rst

7b2ece7

[PORT] From 11.0

f5211bf

[ADD] mgmtsystem_nonconformity: Add activities to nonconformity Add the activities to the model "nonconformity"

[UPD] Update mgmtsystem_nonconformity.pot

162a693

mgmtsystem_nonconformity 12.0.1.1.0

3dee693

[FIX] mgmtsystem_nonconformity: Proper script

0dbaef9

Without decorator, you receive a cursor, not an environment

[IMP] mgmtsystem_nonconformity: black, isort

1b98015

Tardo suggested changes Nov 27, 2019

View reviewed changes

chienandalu approved these changes Nov 28, 2019

View reviewed changes

[MIG] mgmtsystem_nonconformity: Migration to 13.0

7d1096d

ernestotejeda force-pushed the 13.0-mig-mgmtsystem_nonconformity branch from 05ba650 to 7d1096d Compare November 28, 2019 15:05

pedrobaeza approved these changes Nov 30, 2019

View reviewed changes

OCA-git-bot mentioned this pull request Nov 30, 2019

Migration to version 13.0 #262

Open

21 tasks

OCA-git-bot added a commit that referenced this pull request Nov 30, 2019

Merge PR #275 into 13.0

92a438d

Signed-off-by pedrobaeza

OCA-git-bot merged commit 7d1096d into OCA:13.0 Nov 30, 2019

OCA-git-bot added the merged 🎉 label Nov 30, 2019

max3903 added this to the 13.0 milestone Mar 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[13.0][MIG] mgmtsystem_nonconformity: Migration to 13.0 #275

[13.0][MIG] mgmtsystem_nonconformity: Migration to 13.0 #275

Uh oh!

ernestotejeda commented Nov 27, 2019

Uh oh!

oca-clabot commented Nov 27, 2019

Uh oh!

Uh oh!

Tardo Nov 27, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tardo Nov 27, 2019

Uh oh!

Tardo Nov 27, 2019

Uh oh!

Tardo Nov 27, 2019

Uh oh!

Tardo Nov 27, 2019

Uh oh!

chienandalu left a comment

Uh oh!

ernestotejeda commented Nov 28, 2019

Uh oh!

pedrobaeza commented Nov 30, 2019

Uh oh!

OCA-git-bot commented Nov 30, 2019

Uh oh!

OCA-git-bot commented Nov 30, 2019

Uh oh!

Uh oh!

		@@ -0,0 +1,23 @@
		##############################################################################

Uh oh!

[13.0][MIG] mgmtsystem_nonconformity: Migration to 13.0 #275

[13.0][MIG] mgmtsystem_nonconformity: Migration to 13.0 #275

Uh oh!

Conversation

ernestotejeda commented Nov 27, 2019

Uh oh!

oca-clabot commented Nov 27, 2019

Uh oh!

Uh oh!

Tardo Nov 27, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tardo Nov 27, 2019

Choose a reason for hiding this comment

Uh oh!

Tardo Nov 27, 2019

Choose a reason for hiding this comment

Uh oh!

Tardo Nov 27, 2019

Choose a reason for hiding this comment

Uh oh!

Tardo Nov 27, 2019

Choose a reason for hiding this comment

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

ernestotejeda commented Nov 28, 2019

Uh oh!

pedrobaeza commented Nov 30, 2019

Uh oh!

OCA-git-bot commented Nov 30, 2019

Uh oh!

OCA-git-bot commented Nov 30, 2019

Uh oh!

Uh oh!