Skip to content

[13.0][MIG] document_page_health_safety_manual & mgmtsystem_health_safety #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

flachica
Copy link
Contributor

@NachoAles @guadaltech @max3903 Thanks for the reviews

Maxime Chambreuil and others added 30 commits March 17, 2020 08:30
It was spurious and it doesn't work on OpenERP 7.0
@flachica flachica mentioned this pull request Mar 17, 2020
21 tasks
@max3903
Copy link
Member

max3903 commented Mar 17, 2020

@flachica Please separate the branch to have one module per pull request.

If you need a consolidated branch for your project, I suggest you look at git-aggregator: https://pypi.org/project/git-aggregator/

@flachica
Copy link
Contributor Author

@flachica Please separate the branch to have one module per pull request.

If you need a consolidated branch for your project, I suggest you look at git-aggregator: https://pypi.org/project/git-aggregator/

If I make a PR with mgmtsystem_health_safety migration, will fail. mgmtsystem_health_safety depend document_page_health_safety_manual. What is the advantage of doing the PR separately? I execute git format-patch --keep-subject --stdout origin/13.0..origin/12.0 -- $MODULE | git am -3 --keep before complete migration.

@max3903
Copy link
Member

max3903 commented Mar 17, 2020

@flachica It is easier to review one single module at a time, so your pull request will be merged quicker.

@flachica flachica closed this Mar 17, 2020
@flachica flachica deleted the 13.0-mig-document_page_health_safety_manual branch March 17, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants