-
-
Notifications
You must be signed in to change notification settings - Fork 320
[13.0][MIG] document_page_environment_manual #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] document_page_environment_manual #324
Conversation
When will this be merged? #303 is failing on this being missing. I can volunteer to do some stuff if needed. |
I have migrated all the modules I was missing to version 13.0. Use this repository https://github.com/flachica/management-system and the branchs in case it helps you. On some occasion I had problems with the git rebase but all the code is working in my test environment |
Thanx for info. I'll wait a bit I guess to see if this gets going on. |
/ocabot merge nobump |
On my way to merge this fine PR! |
@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-324-by-ivantodorovich-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
This PR has the |
document_page doesn't seem to support MediaWiki syntax anymore.
e6bd9cc
to
9f5ab79
Compare
@ivantodorovich This error is new for me. Flake8 don't understand a correct sentence in my opinion |
Can you rebase on 13.0 ?
Maybe there where changes in precommit that are not in this branch
Le jeu. 21 mai 2020 à 16:35, Fernando <[email protected]> a écrit :
… @ivantodorovich <https://github.com/ivantodorovich> your merge command
was aborted due to failed check(s), which you can inspect on this commit
of 13.0-ocabot-merge-pr-324-by-ivantodorovich-bump-nobump
<https://github.com/OCA/management-system/commits/3e13ad5f057865d76aebba3173bc66672367ae05>
.
After fixing the problem, you can re-issue a merge command. Please refrain
from merging manually as it will most probably make the target branch red.
@ivantodorovich <https://github.com/ivantodorovich> This error is new for
me. Flake8 don't understand a correct sentence in my opinion
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOTKSMG2MNESCAYGCWHDK3RSU32BANCNFSM4L2RX7OA>
.
|
@ivantodorovich Of course, the rebase was initiated 15 minutes ago here |
How is this going? Can I help with anything? |
All clear, just please squash |
I guess only @flachica can do that, right? |
9f5ab79
to
8a61469
Compare
@Rad0van @ivantodorovich It is done |
Fantastic! Thank you. Will this be merged automatically or someone has to to sign it off? |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 2d4685f. Thanks a lot for contributing to OCA. ❤️ |
Many conflicts on git format-patch. This PR solve #302 problems