-
-
Notifications
You must be signed in to change notification settings - Fork 525
[18.0][MIG] mrp_multi_level #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JasminSForgeFlow Just today, we merged some changes and 2 new commits that you need to include here https://github.com/OCA/manufacture/commits/17.0/mrp_multi_level. Could you do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JasminSForgeFlow , small changes that might improve the readme:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for matching id and name
* You can know integrate with different forecasting mechanisms. As a consequence integration with stock_demand_estimate is moved to a new module (mrp_multi_level_estimate). * As agreed by the authors, the module is re-licensed to LGPL-3.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/
add another exclude point at planned order creation.
Currently translated at 67.1% (100 of 149 strings) Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/es/
demand moves have the same date it can happen that the supply is effectively ignored if considered as staring move of the grouping and there are more groups to be done after it. A test case include in this fix depicts in detail the the problem and ensures no regression.
Currently translated at 3.4% (5 of 149 strings) Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-13.0/manufacture-13.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-13-0/manufacture-13-0-mrp_multi_level/
…sition. It isn't the most common filter used.
When you procure a kit, it doesn't matter what the route configuration is on the product itself but on its children, so it is not needed to check anything else but the BoM to assign the 'phantom' supply method. Also do not assign a BoM when the supply method is not phantom or manufacture.
After odoo/odoo@1ed6dbe we need to explicitly set routes in the propoer order becouse while in the cache there are not yet sorted by sequence (it requires flush to the database, which we cannot do in a test).
ChrisOForgeFlow is not longer active.
9a92653
to
e848f2e
Compare
Done, Thanks |
Done, Thanks |
<group colspan="4" col="2"> | ||
<group> | ||
<field name="active" invisible="1" /> | ||
<field name="warehouse_id" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jasmin,
We could adjust this to avoid a small bug that occurs when clicking "New" on the warehouse_id field if the Storage Locations setting is not active. Let me know what you think! 😊
<field name="warehouse_id" /> | |
<field name="warehouse_id" | |
options="{'no_create': True, 'no_create_edit': True}" | |
force_save="1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a separate PR about that small issue: #1424. Maybe it's better to keep it separated from the migration.
e848f2e
to
86bf57b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, functional test is also good 👍
/ocabot migration mrp_multi_level /ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 6f2929f. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration
@ForgeFlow