[18.0][MIG] mrp_multi_level #1411

JasminSForgeFlow · 2024-12-03T12:35:19Z

Standard Migration

LoisRForgeFlow · 2024-12-03T12:59:14Z

@JasminSForgeFlow Just today, we merged some changes and 2 new commits that you need to include here https://github.com/OCA/manufacture/commits/17.0/mrp_multi_level. Could you do it?

RicardCForgeFlow

Hi @JasminSForgeFlow , small changes that might improve the readme:

RicardCForgeFlow · 2024-12-03T14:36:02Z

mrp_multi_level/readme/CONFIGURE.md

@@ -0,0 +1,9 @@
+## MRP Areas


Suggested change

## MRP Areas

### MRP Areas

RicardCForgeFlow · 2024-12-03T14:36:08Z

mrp_multi_level/readme/CONFIGURE.md

+- Go to *Manufacturing \> Configuration \> MRP Areas* and define or edit
+  any existing area. You can specify the working hours for every area.
+
+## Product MRP Area Parameters


Suggested change

## Product MRP Area Parameters

### Product MRP Area Parameters

RicardCForgeFlow · 2024-12-03T14:36:20Z

mrp_multi_level/readme/USAGE.md

@@ -0,0 +1,12 @@
+To manually run the MRP scheduler:
+
+1.  Go to *Manufacturing \> Operations \> Run MRP Multi Level*.


Suggested change

1. Go to *Manufacturing \> Operations \> Run MRP Multi Level*.

1. Go to *Manufacturing \> Planning \> Run MRP Multi Level*.

RicardCForgeFlow · 2024-12-03T14:36:25Z

mrp_multi_level/readme/USAGE.md

+
+To launch replenishment orders (moves, purchases, production orders...):
+
+1.  Go to *Manufacturing \> Operations \> MRP Inventory*.


Suggested change

1. Go to *Manufacturing \> Operations \> MRP Inventory*.

1. Go to *Manufacturing \> Planning \> MRP Inventory*.

RicardCForgeFlow · 2024-12-03T15:34:42Z

mrp_multi_level/models/product_mrp_area.py

+            )
+
+    @api.model
+    def _name_search(self, name, domain=None, operator="ilike", limit=None, order=None):


https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#:~:text=_name_search%20is%20gone%2C%20replaced%20by%20_search_display_name.

Maybe we should replace this:

Suggested change

def _name_search(self, name, domain=None, operator="ilike", limit=None, order=None):

def _search_display_name(self, name, domain=None, operator="ilike", limit=None, order=None):

RicardCForgeFlow · 2024-12-03T15:34:49Z

mrp_multi_level/models/product_mrp_area.py

+                    ],
+                ]
+            )
+        return super()._name_search(name, domain, operator, limit, order)


Suggested change

return super()._name_search(name, domain, operator, limit, order)

return super()._search_display_name(name, domain, operator, limit, order)

RicardCForgeFlow · 2024-12-03T15:34:57Z

mrp_multi_level/tests/test_mrp_multi_level.py

+        )
+        self.assertNotEqual(this.create_uid, prev.create_uid)
+
+    def test_11_special_scenario_1(self):


This is a bit silly, but we could change the number of the tests, it seems that there is no number 10.

Suggested change

def test_11_special_scenario_1(self):

def test_10_special_scenario_1(self):

If we do this we should change them all > 11

RicardCForgeFlow

Suggestion for matching id and name

RicardCForgeFlow · 2024-12-03T16:46:13Z

mrp_multi_level/views/mrp_area_views.xml

@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record model="ir.ui.view" id="mrp_area_tree">


Suggested change

<record model="ir.ui.view" id="mrp_area_tree">

<record model="ir.ui.view" id="mrp_area_list">

RicardCForgeFlow · 2024-12-03T16:47:28Z

mrp_multi_level/views/mrp_area_views.xml

+        <field name="res_model">mrp.area</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="view_mode">list,form</field>
+        <field name="view_id" ref="mrp_area_tree" />


Suggested change

<field name="view_id" ref="mrp_area_tree" />

<field name="view_id" ref="mrp_area_list" />

RicardCForgeFlow · 2024-12-03T16:47:36Z

mrp_multi_level/views/mrp_inventory_views.xml

+            </form>
+        </field>
+    </record>
+    <record id="mrp_inventory_tree" model="ir.ui.view">


Suggested change

<record id="mrp_inventory_tree" model="ir.ui.view">

<record id="mrp_inventory_list" model="ir.ui.view">

RicardCForgeFlow · 2024-12-03T16:48:05Z

mrp_multi_level/views/mrp_inventory_views.xml

+        <field name="res_model">mrp.inventory</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="view_mode">list,form,pivot,graph</field>
+        <field name="view_id" ref="mrp_inventory_tree" />


Suggested change

<field name="view_id" ref="mrp_inventory_tree" />

<field name="view_id" ref="mrp_inventory_list" />

RicardCForgeFlow · 2024-12-03T16:48:32Z

mrp_multi_level/views/mrp_move_views.xml

@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record id="mrp_move_view_tree" model="ir.ui.view">


Suggested change

<record id="mrp_move_view_tree" model="ir.ui.view">

<record id="mrp_move_view_list" model="ir.ui.view">

RicardCForgeFlow · 2024-12-03T16:48:57Z

mrp_multi_level/views/mrp_planned_order_views.xml

+<!-- Copyright 2019-20 ForgeFlow S.L. (https://www.forgeflow.com)
+     Part of ForgeFlow. See LICENSE file for full copyright and licensing details. -->
+<odoo>
+    <record id="mrp_planned_order_view_tree" model="ir.ui.view">


Suggested change

<record id="mrp_planned_order_view_tree" model="ir.ui.view">

<record id="mrp_planned_order_view_list" model="ir.ui.view">

RicardCForgeFlow · 2024-12-03T16:49:14Z

mrp_multi_level/views/product_mrp_area_views.xml

@@ -0,0 +1,183 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record model="ir.ui.view" id="product_mrp_area_tree">


Suggested change

<record model="ir.ui.view" id="product_mrp_area_tree">

<record model="ir.ui.view" id="product_mrp_area_list">

RicardCForgeFlow · 2024-12-03T16:49:34Z

mrp_multi_level/views/product_mrp_area_views.xml

+        <field name="res_model">product.mrp.area</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="view_mode">list,form</field>
+        <field name="view_id" ref="product_mrp_area_tree" />


Suggested change

<field name="view_id" ref="product_mrp_area_tree" />

<field name="view_id" ref="product_mrp_area_list" />

* You can know integrate with different forecasting mechanisms. As a consequence integration with stock_demand_estimate is moved to a new module (mrp_multi_level_estimate). * As agreed by the authors, the module is re-licensed to LGPL-3.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/

add another exclude point at planned order creation.

Currently translated at 67.1% (100 of 149 strings) Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/es/

demand moves have the same date it can happen that the supply is effectively ignored if considered as staring move of the grouping and there are more groups to be done after it. A test case include in this fix depicts in detail the the problem and ensures no regression.

Currently translated at 3.4% (5 of 149 strings) Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/hr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-13.0/manufacture-13.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-13-0/manufacture-13-0-mrp_multi_level/

…sition. It isn't the most common filter used.

- Index the planned_order_id column on mrp.production model - Delete from mrp.planned.order before deleting from mrp.inventory

fixes OCA#1362 Ignoring qty_available for phantom products prevents double counting the qty_available of components. Creating planned orders for phantom products is simpler than recursively exploding phantom BOMs. This also makes it easier to analyze the planning data generated by the MRP calculation.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-17.0/manufacture-17.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-mrp_multi_level/

fixes OCA#1366 Using the _bom_find() method, we get the BOM with lowest sequence, whether it's a variant BOM or a template BOM (no product_id).

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-17.0/manufacture-17.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-mrp_multi_level/

Currently translated at 100.0% (170 of 170 strings) Translation: manufacture-17.0/manufacture-17.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-mrp_multi_level/it/

_should_create_planned_order hook was unnoticely removed in 33cf4af as it was not needed anymore in the base module. However it is still an extension point that can be used.

When you procure a kit, it doesn't matter what the route configuration is on the product itself but on its children, so it is not needed to check anything else but the BoM to assign the 'phantom' supply method. Also do not assign a BoM when the supply method is not phantom or manufacture.

After odoo/odoo@1ed6dbe we need to explicitly set routes in the propoer order becouse while in the cache there are not yet sorted by sequence (it requires flush to the database, which we cannot do in a test).

ChrisOForgeFlow is not longer active.

JasminSForgeFlow · 2024-12-04T04:41:36Z

@JasminSForgeFlow Just today, we merged some changes and 2 new commits that you need to include here https://github.com/OCA/manufacture/commits/17.0/mrp_multi_level. Could you do it?

Done, Thanks

JasminSForgeFlow · 2024-12-04T04:41:59Z

Hi @JasminSForgeFlow , small changes that might improve the readme:

Done, Thanks

RicardCForgeFlow · 2024-12-05T14:26:22Z

mrp_multi_level/readme/CONFIGURE.md

+
+### Product MRP Area Parameters
+
+- Go to *Manufacturing \> Master Data \> Product MRP Area Parameters*


Little change here:

Suggested change

- Go to *Manufacturing \> Master Data \> Product MRP Area Parameters*

- Go to *Manufacturing \> Products \> Product MRP Area Parameters*

RicardCForgeFlow · 2024-12-05T15:51:44Z

mrp_multi_level/views/mrp_area_views.xml

+                    <group colspan="4" col="2">
+                        <group>
+                            <field name="active" invisible="1" />
+                            <field name="warehouse_id" />


Hi Jasmin,

We could adjust this to avoid a small bug that occurs when clicking "New" on the warehouse_id field if the Storage Locations setting is not active. Let me know what you think! 😊

Suggested change

<field name="warehouse_id" />

<field name="warehouse_id"

options="{'no_create': True, 'no_create_edit': True}"

force_save="1"/>

I did a separate PR about that small issue: #1424. Maybe it's better to keep it separated from the migration.

RicardCForgeFlow reviewed Dec 3, 2024

View reviewed changes

OCA-git-bot and others added 26 commits December 4, 2024 09:42

mrp_multi_level 11.0.3.1.0

277b176

[11.0][MIG] mrp_multi_level: open MRP inventory screen if manually run

82cd356

mrp_multi_level 11.0.3.1.1

26a675e

[UPD] README.rst

511f020

[12.0][MIG] mrp_multi_level:

d750aae

* You can know integrate with different forecasting mechanisms. As a consequence integration with stock_demand_estimate is moved to a new module (mrp_multi_level_estimate). * As agreed by the authors, the module is re-licensed to LGPL-3.

add support for multi-company

529f39f

[UPD] Update mrp_multi_level.pot

31e7593

[UPD] README.rst

1fa8eb2

Update translation files

a58774c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/

[12.0][FIX] mrp_multi_level: creating undesired planned orders.

3589f59

add another exclude point at planned order creation.

Translated using Weblate (Spanish)

4e07693

Currently translated at 67.1% (100 of 149 strings) Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/es/

mrp_multi_level 12.0.1.0.1

bb86b03

Added translation using Weblate (Croatian)

2cd64d7

Translated using Weblate (Croatian)

9000ab5

Currently translated at 3.4% (5 of 149 strings) Translation: manufacture-12.0/manufacture-12.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_multi_level/hr/

[IMP] mrp_multi_level: black, isort

2c18d11

[13.0][MIG] mrp_multi_level

8a17a43

[UPD] Update mrp_multi_level.pot

584fbed

[UPD] README.rst

d0a6bef

Update translation files

396dbcd

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-13.0/manufacture-13.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-13-0/manufacture-13-0-mrp_multi_level/

[IMP] mrp_multi_level: Show supply method on mrp inventory

1bb0ef7

[FIX] Allow no-MRP users to look into Products

fe758cc

[13.0][FIX] mrp_multi_level: wrong multi company rules

5db56f2

[FIX] mrp_multi_level: company in the search view move to the last po…

c9e2d43

…sition. It isn't the most common filter used.

mrp_multi_level 13.0.1.0.1

851f514

[UPD] Update mrp_multi_level.pot

303567d

OCA-git-bot and others added 22 commits December 4, 2024 09:42

[BOT] post-merge updates

ed97212

[IMP] mrp_multi_level: mrp cleanup performance

e5d81dc

- Index the planned_order_id column on mrp.production model - Delete from mrp.planned.order before deleting from mrp.inventory

[BOT] post-merge updates

34cc2cc

[UPD] Update mrp_multi_level.pot

54a12b2

[BOT] post-merge updates

831bd56

Update translation files

9236e43

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-17.0/manufacture-17.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-mrp_multi_level/

[FIX] mrp_multi_level: check for variant bom

9e8a5ae

fixes OCA#1366 Using the _bom_find() method, we get the BOM with lowest sequence, whether it's a variant BOM or a template BOM (no product_id).

[UPD] Update mrp_multi_level.pot

99d8f81

[BOT] post-merge updates

512af2c

Update translation files

ee52d55

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-17.0/manufacture-17.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-mrp_multi_level/

Translated using Weblate (Italian)

5d7b261

Currently translated at 100.0% (170 of 170 strings) Translation: manufacture-17.0/manufacture-17.0-mrp_multi_level Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-mrp_multi_level/it/

[FIX] mrp_multi_level: readd extensibility hook

acb7960

_should_create_planned_order hook was unnoticely removed in 33cf4af as it was not needed anymore in the base module. However it is still an extension point that can be used.

[BOT] post-merge updates

ece3e7f

[FIX] mrp_multi_level: adapt tests to recent upstream changes.

d84964c

After odoo/odoo@1ed6dbe we need to explicitly set routes in the propoer order becouse while in the cache there are not yet sorted by sequence (it requires flush to the database, which we cannot do in a test).

[BOT] post-merge updates

df73772

[FIX] mrp_multi_level: delete params on cascade when deleting product.

38e27ef

[UPD] ddmrp: update maintainers

e35ef81

ChrisOForgeFlow is not longer active.

[BOT] post-merge updates

c38c87b

[IMP] mrp_multi_level: black, isort, prettier

1fae464

[MIG] mrp_multi_level: Migration to 18.0

e848f2e

JasminSForgeFlow force-pushed the 18.0-mig-mrp_multi_level branch from 9a92653 to e848f2e Compare December 4, 2024 04:41

JasminSForgeFlow mentioned this pull request Dec 5, 2024

[18.0][MIG] mrp_multi_level_estimate #1412

Open

RicardCForgeFlow reviewed Dec 5, 2024

View reviewed changes

LoisRForgeFlow requested a review from RicardCForgeFlow December 9, 2024 12:56

RicardCForgeFlow approved these changes Dec 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] mrp_multi_level #1411

[18.0][MIG] mrp_multi_level #1411

JasminSForgeFlow commented Dec 3, 2024

LoisRForgeFlow commented Dec 3, 2024

RicardCForgeFlow left a comment

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow left a comment

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

RicardCForgeFlow Dec 3, 2024

JasminSForgeFlow commented Dec 4, 2024

JasminSForgeFlow commented Dec 4, 2024

RicardCForgeFlow Dec 5, 2024

RicardCForgeFlow Dec 5, 2024

RicardCForgeFlow Dec 18, 2024

	## Product MRP Area Parameters
	### Product MRP Area Parameters

		@@ -0,0 +1,12 @@
		To manually run the MRP scheduler:

		1. Go to Manufacturing \> Operations \> Run MRP Multi Level.

	1. Go to Manufacturing \> Operations \> Run MRP Multi Level.
	1. Go to Manufacturing \> Planning \> Run MRP Multi Level.


		To launch replenishment orders (moves, purchases, production orders...):

		1. Go to Manufacturing \> Operations \> MRP Inventory.

	1. Go to Manufacturing \> Operations \> MRP Inventory.
	1. Go to Manufacturing \> Planning \> MRP Inventory.

	def _name_search(self, name, domain=None, operator="ilike", limit=None, order=None):
	def _search_display_name(self, name, domain=None, operator="ilike", limit=None, order=None):

	return super()._name_search(name, domain, operator, limit, order)
	return super()._search_display_name(name, domain, operator, limit, order)

	def test_11_special_scenario_1(self):
	def test_10_special_scenario_1(self):

	<record model="ir.ui.view" id="mrp_area_tree">
	<record model="ir.ui.view" id="mrp_area_list">

	<field name="view_id" ref="mrp_area_tree" />
	<field name="view_id" ref="mrp_area_list" />

	<record id="mrp_inventory_tree" model="ir.ui.view">
	<record id="mrp_inventory_list" model="ir.ui.view">

	<field name="view_id" ref="mrp_inventory_tree" />
	<field name="view_id" ref="mrp_inventory_list" />

	<record id="mrp_move_view_tree" model="ir.ui.view">
	<record id="mrp_move_view_list" model="ir.ui.view">

	<record id="mrp_planned_order_view_tree" model="ir.ui.view">
	<record id="mrp_planned_order_view_list" model="ir.ui.view">

	<record model="ir.ui.view" id="product_mrp_area_tree">
	<record model="ir.ui.view" id="product_mrp_area_list">

	<field name="view_id" ref="product_mrp_area_tree" />
	<field name="view_id" ref="product_mrp_area_list" />


		### Product MRP Area Parameters

		- Go to Manufacturing \> Master Data \> Product MRP Area Parameters

	- Go to Manufacturing \> Master Data \> Product MRP Area Parameters
	- Go to Manufacturing \> Products \> Product MRP Area Parameters

[18.0][MIG] mrp_multi_level #1411

Are you sure you want to change the base?

[18.0][MIG] mrp_multi_level #1411

Conversation

JasminSForgeFlow commented Dec 3, 2024

LoisRForgeFlow commented Dec 3, 2024

RicardCForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RicardCForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JasminSForgeFlow commented Dec 4, 2024

JasminSForgeFlow commented Dec 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment