[16.0][ADD] quality_control_product_manufacturer: Added new module #1553

anusriNPS · 2025-06-26T04:55:48Z

Added a field under "quality_control_oca" module in "qc.inspection" model to display product image with respect to product_id available as part of selection made in reference field of the model.
Added new module which bridges "quality_control_oca" and "product_manufacturer" in order to display details about Manufacturer and Manufacturer Code related to product_id available as part of selection made in Reference field in the Inspection form.

SirPyTech

Thanks for the PR!

SirPyTech · 2025-06-30T08:59:36Z

quality_control_oca/views/qc_inspection_view.xml

-                                <span class="float-end text-end"><t
-                                        t-esc="record.qty.value"
-                                    /></span>
+                                <span class="float-end text-end">
+                                    <t t-esc="record.qty.value" />
+                                </span>


suggestion: There is a lot of refactoring in this commit: if it is needed, please move it to a dedicated [REF] commit so that it's more clear which changes are needed for the improvement that is being added.
Adding the name attribute to the pages can be considered a refactoring too.

Removed changes which were resulted as part of formatting XML. Keeping only changes relevant to requirement and hence used [IMP] tag in the commit for "quality_control_oca" module.

SirPyTech · 2025-06-30T09:03:40Z

quality_control_product_manufacturer_oca/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    "name": "Quality Control Product Manufacturer OCA",
+    "version": "16.0.0.0.1",


chore: The first version number should be 16.0.1.0.0, see https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#12version-numbers:

The version number in the module manifest should be the Odoo major version (e.g. 12.0) followed by the module x.y.z version numbers. For example: 12.0.1.0.0 is expected for the first release of an 12.0 module.

Updated version as required

SirPyTech · 2025-06-30T09:07:09Z

quality_control_product_manufacturer_oca/models/qc_inspection.py

+
+class QcInspection(models.Model):
+    _inherit = "qc.inspection"
+    _description = "Quality control inspection with Manufacturer details"


issue: This is would overwrite the description of the model qc.inspection.
If you want to keep this note, please add it as a class docstring or a simple comment.

Updated using comment in the model file introduced

SirPyTech · 2025-06-30T09:25:45Z

quality_control_product_manufacturer_oca/views/qc_inspection_views.xml

+            <xpath expr="//page[@name='notes']" position="after">
+                <page
+                    string="Manufacturer"
+                    attrs="{'invisible': [('object_id', '=', False), ('object_id', '!=', 'product.product')]}"


suggestion: Since the fields in this page depend on the selected product, it would make sense to show it only if there is a product (product_id) selected, what do you think?

question: I'm not sure the field object_id could ever be product.product: because it is a Reference field and they are stored as model.name,model_id, could you please check if this condition is working as expected?

Updated domain using "product_id" as well.

Please find answer in below comment related to "object_id" query

SirPyTech · 2025-06-30T09:28:11Z

quality_control_product_manufacturer_oca/views/qc_inspection_views.xml

+        <field name="arch" type="xml">
+            <xpath expr="//page[@name='notes']" position="after">
+                <page
+                    string="Manufacturer"


suggestion: Add a name attribute: it is useful for inheriting views (as you have just found out in this exact PR 😉)

Yes, it was missed and I have updated now

SirPyTech · 2025-06-30T09:39:57Z

quality_control_product_manufacturer_oca/views/qc_inspection_views.xml

+                 <field name="manufacturer" />
+                 <field name="manufacturer_code" />


question: I believe that fields should be stored in order to be searchable, could you please check that searching using these fields is working as expected?
I tried in runboat but I can't select products for a related test:

Apologies for misleading information as part of commit message, which lead you to check under "Test" form for "Reference" field. So, I have updated as required.

The model "qc.inspection" has form view under "Inspection" where object_id can be found with "product.product". Runboat installation as below:

Tree view:

Also, search is achievable without using store attribute for fields. Please find image as below where test1 has "manufacturer_code" as 1234556 and test3 has "manufacturer_code" as "123456" and result is as expected.

Thanks for the explanation! It looks fine then 👍

SirPyTech · 2025-06-30T09:47:43Z

quality_control_product_manufacturer_oca/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    "name": "Quality Control Product Manufacturer OCA",


note: The _oca suffix in the module's folder can be removed: it is normally used to avoid name clashing with Odoo's modules.
For instance, the module quality_control_oca has the _oca suffix so it doesn't clash with Odoo enterprise's module quality_control, see #481 (comment).

Thank for the detailed reference. Removed "_oca" prefix in the newly introduced module

SirPyTech · 2025-06-30T09:52:04Z

quality_control_oca/models/qc_inspection.py

chore: The commit's title should start with [IMP] instead of [ADD], see https://www.odoo.com/documentation/16.0/contributing/development/git_guidelines.html#tag-and-module-name:

[ADD] for adding new modules;

[IMP] for improvements: most of the changes done in development version are incremental improvements not related to another tag;
[...]

In OCA we also have [MIG] (see https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message).

[ADD] tag was wrongly used though I was aware of OCA convention for commit message. Will be cautious here on while making a commit message.

SirPyTech

Looks great 👏 thanks!

SirPyTech · 2025-07-01T07:18:37Z

quality_control_oca/models/qc_inspection.py

SirPyTech · 2025-07-01T07:19:27Z

quality_control_oca/views/qc_inspection_view.xml

-                                <span class="float-end text-end"><t
-                                        t-esc="record.qty.value"
-                                    /></span>
+                                <span class="float-end text-end">
+                                    <t t-esc="record.qty.value" />
+                                </span>


SirPyTech · 2025-07-01T07:19:51Z

quality_control_product_manufacturer_oca/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    "name": "Quality Control Product Manufacturer OCA",
+    "version": "16.0.0.0.1",


SirPyTech · 2025-07-01T07:20:12Z

quality_control_product_manufacturer_oca/models/qc_inspection.py

+
+class QcInspection(models.Model):
+    _inherit = "qc.inspection"
+    _description = "Quality control inspection with Manufacturer details"


SirPyTech · 2025-07-01T07:20:48Z

quality_control_product_manufacturer_oca/views/qc_inspection_views.xml

+        <field name="arch" type="xml">
+            <xpath expr="//page[@name='notes']" position="after">
+                <page
+                    string="Manufacturer"


SirPyTech · 2025-07-01T07:23:06Z

quality_control_product_manufacturer_oca/views/qc_inspection_views.xml

+                 <field name="manufacturer" />
+                 <field name="manufacturer_code" />


Thanks for the explanation! It looks fine then 👍

SirPyTech · 2025-07-01T07:23:28Z

quality_control_product_manufacturer_oca/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    "name": "Quality Control Product Manufacturer OCA",


SirPyTech · 2025-07-01T07:28:01Z

quality_control_product_manufacturer_oca/views/qc_inspection_views.xml

+            <xpath expr="//page[@name='notes']" position="after">
+                <page
+                    string="Manufacturer"
+                    attrs="{'invisible': [('object_id', '=', False), ('object_id', '!=', 'product.product')]}"


aleuffre

Code review, LGTM!

aleuffre · 2025-07-01T07:59:33Z

quality_control_oca/models/qc_inspection.py

@@ -66,6 +66,9 @@ def _compute_product_id(self):
        store=True,
        help="Product associated with the inspection",
    )
+    product_image = fields.Image(
+        related="product_id.image_1920", string="Product Image", store=True


question (non-blocking): is it necessary to store this field? This would store a copy of the image on every inspection, instead of fetching it from the product itself.

I think its not necessary to have store for this field, will verify once and update it accordingly.

OCA-git-bot · 2025-07-01T08:03:41Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Added "product_image" field to display product image related to the product selected under "product_id" in the Inspection.

Added module "quality_control_product_manufacturer" to display manufacturer details with respect to "product_id" available from option selected from field "Reference" in the Inspection.

SirPyTech suggested changes Jun 30, 2025

View reviewed changes

anusriNPS force-pushed the 16.0-add-fields branch 4 times, most recently from 811174f to d997b83 Compare June 30, 2025 15:05

SirPyTech approved these changes Jul 1, 2025

View reviewed changes

anusriNPS changed the title ~~[16.0][ADD] quality_control_product_manufacturer_oca: Added new module~~ [16.0][ADD] quality_control_product_manufacturer: Added new module Jul 1, 2025

aleuffre approved these changes Jul 1, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 1, 2025

anusriNPS added 2 commits July 1, 2025 16:08

[IMP] quality_control_oca: Added field under qc_inspection

e41644c

Added "product_image" field to display product image related to the product selected under "product_id" in the Inspection.

[ADD] quality_control_product_manufacturer: Added new module

59c16b1

Added module "quality_control_product_manufacturer" to display manufacturer details with respect to "product_id" available from option selected from field "Reference" in the Inspection.

anusriNPS force-pushed the 16.0-add-fields branch from d997b83 to 59c16b1 Compare July 1, 2025 14:11

		<field name="manufacturer" />
		<field name="manufacturer_code" />

		@@ -0,0 +1,15 @@
		{
		"name": "Quality Control Product Manufacturer OCA",

Uh oh!

[16.0][ADD] quality_control_product_manufacturer: Added new module #1553

Are you sure you want to change the base?

[16.0][ADD] quality_control_product_manufacturer: Added new module #1553

Uh oh!

Conversation

anusriNPS commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SirPyTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anusriNPS Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anusriNPS Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SirPyTech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

anusriNPS commented Jun 26, 2025 •

edited

Loading

anusriNPS Jun 30, 2025 •

edited

Loading

anusriNPS Jun 30, 2025 •

edited

Loading