Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] purchase_sale_container_deposit_inter_company #533

Conversation

santostelmo
Copy link

@santostelmo santostelmo commented Nov 21, 2023

In product_packaging_container_deposit, product packaging container deposit lines added automatically by the system are flagged with (is_container=True).
That information needs to be propagated from the PO to the SO to allow the correct computation of the product packaging container deposit.

Depends:

@santostelmo santostelmo force-pushed the 16.0-add-purchase_sale_container_deposit_inter_company branch from 4ee3e31 to 689a075 Compare November 21, 2023 10:36
@santostelmo santostelmo marked this pull request as draft November 21, 2023 10:38
@santostelmo santostelmo marked this pull request as ready for review November 21, 2023 10:48
@cyrilmanuel
Copy link

shall be repush to check wheelhouse. update PR with minimal change shall retrigger correction ?

@legalsylvain
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@legalsylvain The rebase process failed, because command git push --force camptocamp tmp-pr-533:16.0-add-purchase_sale_container_deposit_inter_company failed with output:

remote: Permission to camptocamp/multi-company.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/camptocamp/multi-company/': The requested URL returned error: 403

@legalsylvain
Copy link
Contributor

hi @santostelmo. could you rebase ? thanks !

@legalsylvain legalsylvain added this to the 16.0 milestone Dec 17, 2023
@santostelmo santostelmo force-pushed the 16.0-add-purchase_sale_container_deposit_inter_company branch from 689a075 to 79bdb7e Compare January 30, 2024 09:16
@santostelmo
Copy link
Author

hi @santostelmo. could you rebase ? thanks !

Rebased

@cyrilmanuel
Copy link

Hii @legalsylvain , is it good for you ? :)

kind regards

@legalsylvain
Copy link
Contributor

hi @cyrilmanuel. I don't use intercompany features. I'm not the good one for the review.

@cyrilmanuel
Copy link

cyrilmanuel commented Mar 27, 2024

hoo sorry @legalsylvain :)

perhaps @pedrobaeza you could help us to review / merge this PR ?

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review, although I don't use this.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-533-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit df605e7 into OCA:16.0 Mar 27, 2024
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 55ecb82. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants