[16.0][MIG] ir_actions_report_multi_company: Migration from Odoo 13.0 to 16.0 #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated the translation files
GabbasovDinar
force-pushed
the
16.0-t3976-ir_actions_report_multi_company-mig-to-16
branch
2 times, most recently
from
1ad19cd to
67403f1
Compare
geomer198
approved these changes
Oct 16, 2024
| """ | ||
| cr.execute(query, (model_name, self.env.companies.ids)) | ||
|
|
||
| report_ids = [report_id for report_id, report_type in cr.fetchall()] |
There was a problem hiding this comment.
report_type variable is not used. Please rename report_type on report_type_.
There was a problem hiding this comment.
@geomer198 renamed
GabbasovDinar
force-pushed
the
16.0-t3976-ir_actions_report_multi_company-mig-to-16
branch
from
67403f1 to
33445c2
Compare
geomer198
approved these changes
Oct 16, 2024
|
Functional LGTM |
Abimael1321
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module was migrated in 13.0 by #364, this migration is on top of it.