Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] replace pkg_resources with importlib.metadata #68

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[FIX] replace pkg_resources with importlib.metadata #68

merged 1 commit into from
Jan 9, 2025

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Jan 8, 2025 •
edited
Loading

Context

  • Before this commit, somehow it results in:

pkg_resources.DistributionNotFound: The 'odoo-module-migrator' distribution was not found and is required by the application

This change

  • Using try...except
  • Take this occasion to use importlib.metadata, successor of pkg_resources

@trisdoan
Copy link
Contributor Author

trisdoan commented Jan 8, 2025

Hello @sebalix, would you mind taking a look at this?

sebalix
sebalix approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, indeed pkg_resources is deprecated, thank you

@sebalix sebalix added the bug Something isn't working label Jan 9, 2025
@sebalix sebalix added this to the 0.18 milestone Jan 9, 2025
@sebalix sebalix merged commit 9e90e61 into OCA:main Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.
2 participants
@trisdoan @sebalix