Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic CI references #180

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use generic CI references #180

wants to merge 3 commits into from

Conversation

SirAionTech
Copy link
Contributor

Travis is no more used

pedrobaeza
pedrobaeza reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment about Codecov checks not being mandatory, which is a recurrent question among beginners.

pedrobaeza
pedrobaeza reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand about being neutral in the denominations, but not sure if people is going to associate coverage <> Codecov. Let's put the exact reference and modify it if this changes in the future.

luisg123v
luisg123v suggested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide commit descriptions.

@luisg123v
Copy link
Contributor

I understand about being neutral in the denominations, but not sure if people is going to associate coverage <> Codecov. Let's put the exact reference and modify it if this changes in the future.

Maybe:

coverage → coverage checks

That way, it will be explicit it refers to the CI checks regarding coverage.

Or in fault:

coverage checks (currently done by codecov)

@SirAionTech
Copy link
Contributor Author

Should be all done.

The first time "coverage CI" is mentioned it is a little verbose to explain that it is done with Codecov.
The following occurrences only say "coverage CI".

Added descriptions to all commits.

Also noticed that Runbot was still there.

luisg123v
luisg123v suggested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave a blank line between commit title and description, please?

SirAionTech and others added 3 commits August 26, 2024 09:23
@SirAionTech
Use generic CI references
a3ccb7f 
Travis is no more used
@SirAionTech
Coverage CI is optional
2258053 
Right now coverage CI is managed with Codecov
@SirAionTech
Runbot is dead
a6e92a6 
All hail Runboat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

@rvalyi rvalyi rvalyi approved these changes

@luisg123v luisg123v Awaiting requested review from luisg123v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SirAionTech @luisg123v @rvalyi @legalsylvain @pedrobaeza @OCA-git-bot