Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] replace editable attribute on list view #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaviedoanhduy
Copy link

replace "1" by "bottom" in editable attribute on list view.
base on: https://github.com/odoo/odoo/pull/162937

an example when migrating account_corporate_budget_base

(env) chien@nmc:~/code/odoo-module-migrator$ python -m odoo_module_migrate -d /home/chien/code/oca/smartcamp_core_private/17.0 -m account_corporate_budget_base -i 17.0 -t 18.0
12:27:39   INFO        Run pre-commit
An error has occurred: InvalidConfigError: 
=====> .pre-commit-config.yaml is not a file
Check the log at /home/chien/.cache/pre-commit/pre-commit.log
12:27:39   INFO        Stage and commit changes done by pre-commit
[pr_son_5 406f009] [IMP] account_corporate_budget_base: pre-commit execution
12:27:39   INFO        [account_corporate_budget_base] Running migration from 17.0 to 18.0
12:27:39   INFO        Bump version to 18.0.1.0.0
12:27:40   ERROR       Error processing file /home/chien/code/oca/smartcamp_core_private/17.0/account_corporate_budget_base/security: [Errno 21] Is a directory: '/home/chien/code/oca/smartcamp_core_private/17.0/account_corporate_budget_base/security'
12:27:40   INFO        Replace editable="1" by "bottom" in file: /home/chien/code/oca/smartcamp_core_private/17.0/account_corporate_budget_base/views/account_move_corporate_budget_line_views.xml
12:27:40   INFO        Commit changes for account_corporate_budget_base. commit name '[MIG] account_corporate_budget_base: Migration to 18.0'

Copy link
Contributor

@lef-adhoc lef-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants