[UPG] Base migration upgrade for fields rename. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BT-dherreros
force-pushed
the
upg-add-field-rename
branch
from
b18e530 to
72db965
Compare
bosd
reviewed
Jan 2, 2025
| absolute_file_path, replaces, "Change file content of %s" % filename | ||
| ) | ||
| field_renames = renamed_fields.get("replaces") | ||
| # To be safe we only rename fields on files associated with the current replaces | ||
| if field_renames: |
There was a problem hiding this comment.
This creates an UnboundLocalError:
module_migration.run()
~~~~~~~~~~~~~~~~~~~~^^
File "/home/data/git/OCA/odoo-module-migrator/odoo_module_migrate/module_migration.py", line 34, in run
migration_script.run(
~~~~~~~~~~~~~~~~~~~~^
self._module_path,
^^^^^^^^^^^^^^^^^^
...<4 lines>...
self._migration._commit_enabled,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/home/data/git/OCA/odoo-module-migrator/odoo_module_migrate/base_migration_script.py", line 160, in run
self.process_file(
~~~~~~~~~~~~~~~~~^
root,
^^^^^
...<4 lines>...
commit_enabled,
^^^^^^^^^^^^^^^
)
^
File "/home/data/git/OCA/odoo-module-migrator/odoo_module_migrate/base_migration_script.py", line 230, in process_file
if re.findall(pattern, new_text):
^^^^^^^^
UnboundLocalError: cannot access local variable 'new_text' where it is not associated with a value
There was a problem hiding this comment.
I've readded the definition of new_text assigned by the call tools._replace_in_file just before the if in L216. It fix the issue, but in any case: how did you ran the code? any specifics that I could add to the unit tests?
There was a problem hiding this comment.
I have merged this pr in my own fork. Then used it to migrate some modules from the brand repo.
BT-dherreros
force-pushed
the
upg-add-field-rename
branch
from
72db965 to
6b23df0
Compare
bosd
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.