[FIX] openupgrade: fix module name retrieval #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Odoo pr #202014 was merged, the 'pkg' key is not present anymore in 'locals', this because the real migration step is executed outside of method that prepare data to run the migration(s). The new method not use the 'pkg' object, but use directly the module name
legalsylvain
approved these changes
Mar 27, 2025
pedrobaeza
approved these changes
Mar 27, 2025
The PR of Odoo was originated by the need to use their upgrade library outside of migration process, with this PRs they allow to use the method merge_modules and rename_modules of their library before base is updated |
|
Yeah, I mean that breaking change... It's true that we were using an "internal variable" and very specific Python code outside Odoo modules, but their stability policy sometimes is not strict where it should be, and it's the excuse other times for not accepting clear patches. Let's move on and thanks again for finding the issue. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error indicated in OCA/l10n-spain#4092 after odoo/odoo#202014 merge, and potentially close the issue #409