16.0 mig base location nuts #1398

Vincenzo9191 · 2022-11-11T09:08:24Z

Migration to version 16.0 for base_location_nuts (issue #1353 )

Changed library for HTTP GET from requests to urllib3;
Changed test class to TestBaseLocationNuts(common.TransactionCase) because SavepointCase has been merged in TransactionCase;

[MIG] Rename manifest files

This makes NUTS labels and levels to be stored in the res.country object. Now creating l10n submodules is a piece of cake! Relational fields now follow guidelines on naming. Old name attribute used for backwards compatibility wherever needed. Also some methods have been renamed, and refactored to be smarter. Most cases l10n modules will just need to fill the res.contry table, and regions and substates domains will work out of the box. In case you still need to overwrite any method, splitting in smaller methods makes it easier too. Oh! And no need for recursive dictionary updates. Return dict() to make it easier for submodules to add domains. Fix KeyError: 'substate_id_level'.

Fix linter. Fix typo.

tafaRU

Thanks for your PR!
Please squash administrative commits for reducing commit noise according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

The rest LGTM, also tested 👍

tafaRU · 2022-11-25T15:16:42Z

base_location_nuts/wizard/nuts_import.py

@@ -121,7 +121,7 @@ def _mapping(self, node):
            else:
                logger.debug("xpath = '%s', not found" % field_xpath)
            if field_required and not value:
-                raise UserError(_("Value not found for mandatory field %s" % k))
+                raise UserError(_("Value not found for mandatory field %s") % k)


Good catch!

base_location_nuts/wizard/nuts_import.py

tafaRU · 2022-12-14T14:35:47Z

@Vincenzo9191 there is still #1398 (review) to address. Could you please take a look?

Vincenzo9191 · 2022-12-27T12:07:40Z

@Vincenzo9191 there is still #1398 (review) to address. Could you please take a look?

@tafaRU thank you for your review;
If may ask, can you address me the initial and last commit to squash to follow the comunity guidelines?

tafaRU · 2023-01-13T10:50:18Z

@Vincenzo9191
the first one is the following:

while the last one is:

In the middle the others!

Please note that in case of multiple administrative commits as the following:

you have to squash all the commits to only one, the real one!

…except. (OCA#506) OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex [UPD] Update base_location_nuts.pot

tafaRU · 2023-01-20T09:27:34Z

@Vincenzo9191 @FrancescoCosma there are still administrative commits need to be squashed:

Could you also please squash these latter?

rousseldenis · 2023-01-20T16:37:54Z

/ocabot migration base_location_nuts

[UPD] Update base_location_nuts.pot [UPD] README.rst Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update base_location_nuts.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-base_location_nuts Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location_nuts/

[UPD] Update base_location_nuts.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-base_location_nuts Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location_nuts/ [UPD] README.rst

primes2h · 2023-02-16T15:35:12Z

@Vincenzo9191 @FrancescoCosma

Please make a fixup combining these two commits in one too. Aside from that, LGTM.

tafaRU · 2023-03-10T09:05:55Z

@Vincenzo9191 @FrancescoCosma could you please address the last comment? So we can proceed with the merge.
Thank you in advance.

Currently translated at 79.5% (31 of 39 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location_nuts Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location_nuts/it/ Translated using Weblate (Italian) Currently translated at 82.1% (32 of 39 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location_nuts Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location_nuts/it/

[UPD] Update base_location_nuts.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-13.0/partner-contact-13.0-base_location_nuts Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-base_location_nuts/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-13.0/partner-contact-13.0-base_location_nuts Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-base_location_nuts/

Currently translated at 100.0% (39 of 39 strings) Translation: partner-contact-13.0/partner-contact-13.0-base_location_nuts Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-base_location_nuts/es_AR/

… after import

…rn domain in onchange [UPD] Update base_location_nuts.pot

tafaRU · 2023-04-14T07:59:42Z

@primes2h could you please update your review?

primes2h · 2023-04-18T07:32:50Z

@Vincenzo9191 @FrancescoCosma
Runboat is missing, please force a push to create it.

tafaRU · 2023-05-08T07:05:21Z

@Vincenzo9191 please squash last two commits to only one as the latter is not significant. Thanks!

tafaRU · 2023-05-23T12:13:05Z

@FrancescoCosma could you please have a look at #1398 (comment)?

[FIX] commit for force runboat

EmilioPascual

Code Review OK
Funcional review: I found some problems. I can't download nuts file.

matteoopenf · 2023-07-11T14:14:23Z

Code Review OK Funcional review: I found some problems. I can't download nuts file.

the same problem there is in 14.0

thomaspaulb · 2023-07-19T11:43:28Z

Peeps, the RAMON server seems to have gone offline, and so the download cannot work anymore.

It seems like this has some archived data where we might be able to find the XML, or, we have to refactor in order to use the new sparql endpoint to the data.

pedrobaeza · 2023-07-19T11:47:40Z

The second one seems the correct way to go.

NICO-SOLUTIONS · 2023-07-23T11:21:12Z

The second one seems the correct way to go.

Anybody attacking this issue already?

matteoopenf · 2023-07-23T11:39:18Z

The second one seems the correct way to go.

Anybody attacking this issue already?

Not for now

rafaelbn · 2023-10-19T20:18:13Z

@Vincenzo9191 could you please take care about the XML in the commenst above is the correct one 😄 !

github-actions · 2024-03-10T12:27:35Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Antonio Espinosa and others added 6 commits November 11, 2022 09:28

[ADD] NUTS regions as a base addon

a3853a0

[MIG] Make modules uninstallable

465043f

[MIG] Rename manifest files

Use separate and explicit fields for each NUTS level

6b8b9fa

Make method recieve the level as int.

81ad553

Fix linter. Fix typo.

[MIG] base_location_nuts: Migration to 10.0

2bb420c

Vincenzo9191 mentioned this pull request Nov 11, 2022

[16.0] [MIG] l10n it location nuts OCA/l10n-italy#3029

Closed

Vincenzo9191 force-pushed the 16.0-mig-base_location_nuts branch from 117c7d7 to e550b4a Compare November 25, 2022 09:38

tafaRU requested changes Nov 25, 2022

View reviewed changes

Vincenzo9191 force-pushed the 16.0-mig-base_location_nuts branch 2 times, most recently from 9425f04 to d4a8e70 Compare December 2, 2022 10:29

NL66278 and others added 2 commits January 19, 2023 12:51

[FIX] base_location_nuts: Prevent flake8 error for non-critical bare …

2373d4d

…except. (OCA#506) OCA Transbot updated translations from Transifex

[MIG] base_location_nuts: Migration to 11.0

98fd2ad

OCA Transbot updated translations from Transifex [UPD] Update base_location_nuts.pot

FrancescoCosma force-pushed the 16.0-mig-base_location_nuts branch from d4a8e70 to effcf3b Compare January 19, 2023 12:05

OCA-git-bot added this to the 16.0 milestone Jan 20, 2023

OCA-git-bot mentioned this pull request Jan 20, 2023

Migration to version 16.0 #1353

Open

59 tasks

SimoRubi and others added 3 commits January 30, 2023 09:23

[UPD] base_location_nuts: update based on flag

da91ad0

[UPD] Update base_location_nuts.pot [UPD] README.rst Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.

FrancescoCosma force-pushed the 16.0-mig-base_location_nuts branch from effcf3b to a333a6c Compare January 30, 2023 08:24

tafaRU approved these changes Feb 3, 2023

View reviewed changes

primes2h and others added 2 commits March 10, 2023 12:43

Pre-commit

355a7fd

astirpe and others added 7 commits March 10, 2023 12:43

[IMP] base_location_nuts: black, isort, prettier

fde9dfb

[MIG] base_location_nuts: Migration to 14.0

4640616

[IMP] base_location_nuts: add context on partner form and reload page…

6e3aae7

… after import

[IMP] base_location_nuts: use compute field in domain instead of retu…

c4721ee

…rn domain in onchange [UPD] Update base_location_nuts.pot

[MIG] base_location_nuts: Migration to 16.0

281f159

FrancescoCosma force-pushed the 16.0-mig-base_location_nuts branch from a333a6c to f3e75c1 Compare March 10, 2023 11:44

[FIX] base_location_nuts: fix category in manifest file

0144014

[FIX] commit for force runboat

FrancescoCosma force-pushed the 16.0-mig-base_location_nuts branch from 4060551 to 0144014 Compare May 31, 2023 13:38

EmilioPascual suggested changes Jun 22, 2023

View reviewed changes

thomaspaulb mentioned this pull request Jul 19, 2023

[11.0][IMP] Move repository to github actions OCA/l10n-netherlands#392

Merged

rafaelbn added the needs review label Oct 19, 2023

NL66278 added needs fixing and removed needs review labels Nov 6, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 10, 2024

github-actions bot closed this Apr 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16.0 mig base location nuts #1398

16.0 mig base location nuts #1398

Vincenzo9191 commented Nov 11, 2022

tafaRU left a comment

tafaRU Nov 25, 2022

tafaRU commented Dec 14, 2022

Vincenzo9191 commented Dec 27, 2022

tafaRU commented Jan 13, 2023 •

edited

Loading

tafaRU commented Jan 20, 2023

rousseldenis commented Jan 20, 2023

primes2h commented Feb 16, 2023

tafaRU commented Mar 10, 2023

tafaRU commented Apr 14, 2023

primes2h commented Apr 18, 2023

tafaRU commented May 8, 2023

tafaRU commented May 23, 2023

EmilioPascual left a comment

matteoopenf commented Jul 11, 2023

thomaspaulb commented Jul 19, 2023

pedrobaeza commented Jul 19, 2023

NICO-SOLUTIONS commented Jul 23, 2023

matteoopenf commented Jul 23, 2023

rafaelbn commented Oct 19, 2023

github-actions bot commented Mar 10, 2024

16.0 mig base location nuts #1398

16.0 mig base location nuts #1398

Conversation

Vincenzo9191 commented Nov 11, 2022

tafaRU left a comment

Choose a reason for hiding this comment

tafaRU Nov 25, 2022

Choose a reason for hiding this comment

tafaRU commented Dec 14, 2022

Vincenzo9191 commented Dec 27, 2022

tafaRU commented Jan 13, 2023 • edited Loading

tafaRU commented Jan 20, 2023

rousseldenis commented Jan 20, 2023

primes2h commented Feb 16, 2023

tafaRU commented Mar 10, 2023

tafaRU commented Apr 14, 2023

primes2h commented Apr 18, 2023

tafaRU commented May 8, 2023

tafaRU commented May 23, 2023

EmilioPascual left a comment

Choose a reason for hiding this comment

matteoopenf commented Jul 11, 2023

thomaspaulb commented Jul 19, 2023

pedrobaeza commented Jul 19, 2023

NICO-SOLUTIONS commented Jul 23, 2023

matteoopenf commented Jul 23, 2023

rafaelbn commented Oct 19, 2023

github-actions bot commented Mar 10, 2024

tafaRU commented Jan 13, 2023 •

edited

Loading