Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] partner_affiliate: Migration to 16.0 #1432

Merged
merged 23 commits into from
Dec 30, 2022

Conversation

FernandoRomera
Copy link
Contributor

No description provided.

Raúl Martín and others added 23 commits December 16, 2022 12:05
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
[IMP] partner_affiliate: Readme

[IMP] Small readability improvements

[FIX] Remove copyright from init files

[UPD] README.rst

[UPD] Update partner_affiliate.pot

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update partner_affiliate.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_affiliate/
[UPD] README.rst

Translated using Weblate (Spanish)

Currently translated at 100.0% (9 of 9 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_affiliate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-13.0/partner-contact-13.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_affiliate/
I tried to improve the description to be more precise about what this module does.
Currently translated at 100.0% (8 of 8 strings)

Translation: partner-contact-15.0/partner-contact-15.0-partner_affiliate
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_affiliate/ca/
@FernandoRomera
Copy link
Contributor Author

/ocabot migration partner_affiliate

@OCA-git-bot
Copy link
Contributor

Sorry @FernandoRomera you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@pedrobaeza
Copy link
Member

Why are you spamming all your PRs threads if you don't have the permission to mark an addon to be migrated in any of them?

@FernandoRomera
Copy link
Contributor Author

FernandoRomera commented Dec 16, 2022

I thought that an action of simply notifying the rest of the community could be done by any contributor. I will not do it again.

@pedrobaeza
Copy link
Member

No, it's not, as you may overwrite another legitimate pull request with the same migration. That has to be decided by a PSC or the module maintainer. Become maintainer of some modules.

@FernandoRomera
Copy link
Contributor Author

But that is impossible to happen the first time you try to migrate the module. Therefore it would be legitimate, to inform the community of your action, to avoid duplication of work.

@pedrobaeza
Copy link
Member

Not if you are maintainer on the previous version, but the way to inform that the community is not here, but on the migration issue as centralized place to do that, as for example: #1353 (comment)

@FernandoRomera
Copy link
Contributor Author

#1353

Copy link

@MRomeera MRomeera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Dec 30, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1432-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 30, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1432-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5be8a1a into OCA:16.0 Dec 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bcc9c58. Thanks a lot for contributing to OCA. ❤️

@FernandoRomera FernandoRomera deleted the 16.0-mig-partner_affiliate branch January 2, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.