[18.0][MIG] partner_multi_relation: Migration to 18.0 #1895

BT-mchechlacz · 2024-11-15T11:34:58Z

No description provided.

* API of _auto_init * Menu and groups stuff has moved from base to sales_team in odoo 10

* Fix error on search when leaf is (1, '=', 1) * Another comparison fix with search arguments

…f relation.

* Update README * Python 2to3 * Move relation menus items under contacts * Fix date comparison * Fix cache invalidate on relation write * Bump module version * Remove test_relation_type_unlink_dberror This test is not required because it tests a standard behavior of SQL. If a foreign key column is not nullable, then the foreign row can not be deleted. * Remove utf8 encoding comment * Add missing dependency for partner_multi_relation * Add missing active_test in view action

* Bug Fix * Enable additional columns on res_partner_relation_all. Enable to add additional columns from res_partner_relation in the sql view of res_partner_relation_all. * Only require inverse_name when relation type is not symmetric * Remove deprecated @api.one and replace openerp with odoo * Add website to manifest * Prevent disabling allow_self if reflexive relations exist * Enable deleting/ending invalid relations after deactivating reflexivity. * Handle case of invalid future reflexive relations

Currently translated at 86.6% (84 of 97 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_multi_relation/es/

[IMP] Flake8

…res_id

Fix for error when opening a contact and clicking the smart button. Error Information: File "/opt/odoo/v12/src/partner-contact/partner_multi_relation/models/res_partner.py", line 187, in action_view_relations action['context'].\ AttributeError: 'str' object has no attribute 'update'

Currently translated at 46.4% (45 of 97 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_multi_relation/it/

…unction and no computed function defined

Currently translated at 100.0% (97 of 97 strings) Translation: partner-contact-13.0/partner-contact-13.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_multi_relation/es_AR/

In Odoo v14, ir.actions.act_window have only access rights for admin while a user had read access in previous versions. Odoo provides now a function (_for_xml_id) that returns the action read with sudo.

Currently translated at 100.0% (97 of 97 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_multi_relation/pt/

[UPD] Update partner_multi_relation.pot

Currently translated at 85.4% (82 of 96 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/sl/

Currently translated at 100.0% (96 of 96 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/es/

Currently translated at 100.0% (96 of 96 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-17.0/partner-contact-17.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_multi_relation/

Currently translated at 100.0% (95 of 95 strings) Translation: partner-contact-17.0/partner-contact-17.0-partner_multi_relation Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_multi_relation/sv/

BT-cjimeno

LGTM, left some comments about _() param formatting.

BT-cjimeno · 2024-11-15T13:15:14Z

partner_multi_relation/models/res_partner_relation.py

+                    self.env._(
+                        f"The {side} partner is not applicable for this "
+                        f"relation type."
+                    )


I think the best way to format parameters into a translated string is using:

_("Example %s", params), I am not sure how it works with an fstring or if it works at all.

This also appears in other places, and if the string inside the _() changes, then I think the .po file should also be updated accordingly.

Example:
_("Warning for %s", self.name)

Translation work with fstrings, however this change was unnecessary here, as it would generate additional work to change it in translations.
Regarding _() vs 'self.env._()` - the second option offers small performance improvements and is advised to use that while migrating the code to version 18
odoo/odoo#174844

Hi Marcin, sorry, maybe I didn't explain myself very well. I meant only that the proper way to parse args into a translated string, AFAIK, is by providing the args/kwargs to the _ method, it doesn't matter if it's for the old way:
"_()" or the new "self.env._()".

Here is the doctstring of v18 self.env._ method:

"""Translate the term using current environment's language.

Usage:

self.env._("hello world") # dynamically get module name self.env._("hello %s", "test") self.env._(LAZY_TRANSLATION)

:param source: String to translate or lazy translation
:param ...: args or kwargs for templating
:return: The transalted string
"""

self.env._("hello %s", "test") <--- This is the one I was refering to, instead of doing
self.env._("hello %s") % "test" or .format, or an fstring... These will also work of course, but the _ method already provides options for this, so we should use them instead IMO.

This is another example with kwargs:
self.env._("%(name)s's Timesheets and Planning Analysis", name=self.name)

My bad, I misunderstood you here. I agree with what you wrote and where it was easy fix not requiring changes in translation I went with your suggestions. Where it requires changes in translation files I didn't touch it to avoid problems with updating po files, which could easily lead to incorrect translations. I don't want to break something that is working 😅
Thank you for the great explanation.

partner_multi_relation/models/res_partner_relation.py

partner_multi_relation/models/res_partner_relation_all.py

partner_multi_relation/models/res_partner_relation_type.py

BT-cjimeno

LGTM!

BT-dmoreno

👍🏻

OCA-git-bot · 2024-12-09T09:39:39Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2024-12-09T09:41:09Z

/ocabot migration partner_multi_relation

rousseldenis

Code review

rousseldenis · 2024-12-09T09:42:38Z

partner_multi_relation/models/res_partner_relation.py

            if category and category.id not in partner.category_id.ids:
                raise ValidationError(
-                    _(
+                    self.env._(


Please use translation function arguments instead of format.

rousseldenis · 2024-12-09T09:45:48Z

partner_multi_relation/tests/test_partner_relation_common.py

-        assert "name" in vals, (
-            "Name_inverse missing in vals to create relation type. Vals: %s." % vals
-        )
+        assert (


We are in an Odoo tests context, I would have used standard unitttest functions instead

rousseldenis · 2024-12-09T09:46:46Z

partner_multi_relation/models/res_partner.py

+    in various ways.
+    """
+
+    # pylint: disable=invalid-name


Do those pylint disables still applicable ?

rousseldenis · 2024-12-09T09:47:39Z

partner_multi_relation/models/res_partner.py

+        )
+        if operator not in SUPPORTED_OPERATORS:
+            raise exceptions.ValidationError(
+                self.env._('Unsupported search operator "%s"') % operator


Please use translation arguments instead.

rousseldenis · 2024-12-09T09:49:20Z

partner_multi_relation/models/res_partner.py

+        for contact in self:
+            relation_model = self.env["res.partner.relation.all"]
+            relation_ids = relation_model.search(
+                [


Putting this domain in action domain will avoid a search().

rousseldenis · 2024-12-09T09:59:51Z

partner_multi_relation/models/res_partner_relation_type.py

+
+        :return: a recordset of res.partner.relation.
+        """
+        self.env.cr.execute(


I'm wondering if flush with fields should be done.

rousseldenis · 2024-12-09T10:00:21Z

partner_multi_relation/models/res_partner_relation_type.py

+                        "type {relation_type}. There are existing reflexive "
+                        "relations defined for the following partners: "
+                        "{partners}"
+                    ).format(


Please use translation function arguments instead.

rousseldenis · 2024-12-09T10:00:32Z

partner_multi_relation/models/res_partner_relation_type.py

+        """Delete existing reflexive relations for these relation types."""
+        for relation_type in self:
+            relations = relation_type._get_reflexive_relations()
+            relations.unlink()


Same as above

rousseldenis · 2024-12-09T10:04:31Z

partner_multi_relation/models/res_partner_relation_type.py

+            if rec.handle_invalid_onchange == "delete":
+                # Automatically delete relations, so existing relations
+                # do not prevent unlink of relation type:
+                relations = relation_model.search([("type_id", "=", rec.id)])


I would have done one search with records in that case [('type_id' , 'in', self.filtered(lambda rel_type: rel_type.handle_invalid_onchange == "delete").ids)]

rousseldenis · 2024-12-09T10:05:33Z

partner_multi_relation/tests/test_partner_relation_common.py

+
+
+class TestPartnerRelationCommon(common.TransactionCase):
+    def setUp(self):


please convert this to classmethod for performances reasons.

BT-dmoreno · 2024-12-17T11:16:47Z

This PR is going to be replaced by this other one here. The reason is that the account that was used to open this one is not going to be used anymore.

NL66278 and others added 30 commits November 12, 2024 15:29

[MIG] partner_multi_relation: Migration to 10.0

a9f06ec

[FIX] partner_multi_relation: Several fixes:

0570219

* API of _auto_init * Menu and groups stuff has moved from base to sales_team in odoo 10

[IMP] Menu order and v10 deprecations

fa88324

[FIX] partner_multi_relation: Fix errors on searches

2686fb9

* Fix error on search when leaf is (1, '=', 1) * Another comparison fix with search arguments

[IMP] Make partner_multi_relation more extendable.

2d840f5

[FIX] partner_multi_relation. Drop is_inverse from vals on creation o…

a63805e

…f relation.

[FIX] partner_multi_relation. Wrong self instead of this.

960457c

[FIX] partner_multi_relation. Extendable but threadsafe.

8f12d10

Migrate partner_multi_relation to version 12.0

d07868b

[FIX] Context Errors With Active ID

01442bb

[IMP] Flake8

[IMP] Formatting

d979b69

[FIX] remove import statements for tests

53b0b8a

[IMP] Flake8

a663e78

[FIX] partner_multi_relation: fix unlinking of record sets with same …

4eb375d

…res_id

[UPD] Attempt at manipulating context

8b3f32d

[FIX] Contact ID Error

a008c64

[MIG] partner_multi_relation. Black, isort, pretty...

6fe2139

[MIG] partner_multi_relation. Actual 13.0 migration.

aa2ded0

[FIX] Fixing problems with migration of computed fields with search f…

f19b0f8

…unction and no computed function defined

[IMP] partner_multi_relation: black, isort

49f8e1f

[MIG] partner_multi_relation: Migration to 14.0

60dc61e

[FIX] partner_multi_relation: Avoid access error on Relations button

ab4c8dc

In Odoo v14, ir.actions.act_window have only access rights for admin while a user had read access in previous versions. Odoo provides now a function (_for_xml_id) that returns the action read with sudo.

[MIG] partner_multi_relation: Migration to 15.0

a59fcee

[UPD] Update partner_multi_relation.pot

sysadminmatmoz and others added 10 commits November 12, 2024 15:29

[IMP] partner_multi_relation: pre-commit stuff

5cf21cd

[MIG] partner_multi_relation: Migration to 17.0

472e082

[UPD] Update partner_multi_relation.pot

9371a27

[IMP] partner_contact_role: pre-commit execution

6d180bd

[IMP] partner_multi_relation: pre-commit auto fixes

a6b2d03

BT-mchechlacz force-pushed the 18.0-mig-partner_multi_relation branch 3 times, most recently from 311cf71 to 63bed45 Compare November 15, 2024 12:21

BT-cjimeno approved these changes Nov 15, 2024

View reviewed changes

[MIG] partner_multi_relation: Migration to 18.0

5a3c6f7

BT-mchechlacz force-pushed the 18.0-mig-partner_multi_relation branch from 63bed45 to 5a3c6f7 Compare November 18, 2024 15:57

BT-cjimeno approved these changes Nov 18, 2024

View reviewed changes

BT-dmoreno approved these changes Dec 9, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Dec 9, 2024

OCA-git-bot added this to the 18.0 milestone Dec 9, 2024

OCA-git-bot mentioned this pull request Dec 9, 2024

Migration to version 18.0 #1856

Open

46 tasks

rousseldenis requested changes Dec 9, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Dec 9, 2024

BT-dmoreno mentioned this pull request Dec 17, 2024

[18.0][MIG] partner_multi_relation: Migration to 18.0 #1933

Open

rousseldenis closed this Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] partner_multi_relation: Migration to 18.0 #1895

[18.0][MIG] partner_multi_relation: Migration to 18.0 #1895

BT-mchechlacz commented Nov 15, 2024

BT-cjimeno left a comment

BT-cjimeno Nov 15, 2024 •

edited

Loading

BT-mchechlacz Nov 18, 2024

BT-cjimeno Nov 18, 2024 •

edited

Loading

BT-mchechlacz Nov 18, 2024 •

edited

Loading

BT-cjimeno left a comment

BT-dmoreno left a comment

OCA-git-bot commented Dec 9, 2024

rousseldenis commented Dec 9, 2024

rousseldenis left a comment

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

rousseldenis Dec 9, 2024

BT-dmoreno commented Dec 17, 2024



		class TestPartnerRelationCommon(common.TransactionCase):
		def setUp(self):

[18.0][MIG] partner_multi_relation: Migration to 18.0 #1895

[18.0][MIG] partner_multi_relation: Migration to 18.0 #1895

Conversation

BT-mchechlacz commented Nov 15, 2024

BT-cjimeno left a comment

Choose a reason for hiding this comment

BT-cjimeno Nov 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BT-cjimeno Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

BT-mchechlacz Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

BT-cjimeno left a comment

Choose a reason for hiding this comment

BT-dmoreno left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 9, 2024

rousseldenis commented Dec 9, 2024

rousseldenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BT-dmoreno commented Dec 17, 2024

BT-cjimeno Nov 15, 2024 •

edited

Loading

BT-cjimeno Nov 18, 2024 •

edited

Loading

BT-mchechlacz Nov 18, 2024 •

edited

Loading