Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] partner_duns: Replace deprecated SavepointCase with TransactionCase #1953

Merged

Conversation

mb-ife
Copy link

@mb-ife mb-ife commented Jan 9, 2025

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @ivantodorovich,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mb-ife !

Indeed, the SavepointCase has been deprecated.
Thanks for your contribution.

Is it possible to get rid of this merge commit?
image

@@ -5,7 +5,7 @@
{
"name": "Partner DUNS",
"summary": "Set DUNS (Data Universal Numbering System) on partners",
"version": "16.0.1.0.0",
"version": "16.0.1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to manually bump versions. Our merge bot will take care of it for us 😉

@mb-ife mb-ife force-pushed the 3048-16.0-partner_duns_fix_test_warnings branch from 3b85f82 to 0bc9655 Compare January 9, 2025 11:42
@mb-ife mb-ife force-pushed the 3048-16.0-partner_duns_fix_test_warnings branch from 0bc9655 to 0857fa3 Compare January 9, 2025 11:42
@ivantodorovich
Copy link
Contributor

Thanks!

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1953-by-ivantodorovich-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 41c710e into OCA:16.0 Jan 9, 2025
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d707a8a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants