[FIX] [16.0] partner_industry_secondary: Add an option to display Child Industries first on it's name #1958
+128
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shide
force-pushed
the
16.0-better_display_of_industries-partner_industry_secondary
branch
from
abc6a21 to
aad9c44
Compare
…stries first on it's name
Shide
force-pushed
the
16.0-better_display_of_industries-partner_industry_secondary
branch
from
aad9c44 to
8219032
Compare
yajo
approved these changes
Jan 13, 2025
| display_last_child_first = fields.Boolean( | ||
| string="Display Child Industries first", | ||
| help="Set if you want to show the last child industries first " | ||
| "when searching for industries.\nChild (Dad < Grampa < Ancestor)", |
There was a problem hiding this comment.
issue: this affects display, not search AFAICS. Besides, let's be a bit more formal here 😁
Suggested change
| "when searching for industries.\nChild (Dad < Grampa < Ancestor)", | |
| "when displaying industries.\nChild (Parent < Grandparent)", |
| cat_name = f"{cat_name} ({' < '.join(parent_cats)})" | ||
| result.append((cat.id, cat_name)) | ||
| return result | ||
| # Default display (Ancestor / Grandpa / Dad / Child) |
There was a problem hiding this comment.
suggestion: just for the sake of uniformity
Suggested change
| # Default display (Ancestor / Grandpa / Dad / Child) | |
| # Default display (Grandparent / Parent / Child) |
| @@ -7,3 +7,4 @@ | |||
| * Jordi Ballester Alomar <[email protected]> | |||
| * Miquel Raïch <[email protected]> | |||
| * Cristina Martin R. | |||
| * Eduardo de Miguel `Moduon <https://www.moduon.team/>`_ | |||
There was a problem hiding this comment.
I think the official template suggest to put the company within parenthesis:
Suggested change
| * Eduardo de Miguel `Moduon <https://www.moduon.team/>`_ | |
| * Eduardo de Miguel (`Moduon <https://www.moduon.team/>`__) |
| if ( | ||
| self.env["ir.config_parameter"] | ||
| .sudo() | ||
| .get_param("partner_industry_secondary.display_last_child_first") |
There was a problem hiding this comment.
thought: don't you believe the "children first" format would be a better default value?
cc @rafaelbn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to display Child Industries first on it's name.
closes #1954
MT-8595 @moduon @rafaelbn @simahawk @yajo please review if you want :)