[16.0][MIG] product_manufacturer: Migration to 16.0 #1166
Conversation
* New Field Added to store the URL of the product on the manufacturer page. * Added field manufacturer product URL to the product view. * README updated.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Add # -*- encoding: utf-8 -*-
Currently translated at 100.0% (5 of 5 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_manufacturer Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_manufacturer/pt_BR/
Currently translated at 100.0% (5 of 5 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_manufacturer Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_manufacturer/nl/
…uct variant not visible enable manufacturer visibility
FrancoMaxime
force-pushed
the
16.0-mig-product_manufacturer
branch
from
97ee2df to
79a28ce
Compare
FrancoMaxime
force-pushed
the
16.0-mig-product_manufacturer
branch
from
79a28ce to
487a39f
Compare
There was a problem hiding this comment.
Thank you @FrancoMaxime LGTM (Code review + Functional tests)
|
@rousseldenis could you update your review? |
You're welcome |
|
With three approvals and all other comments honoured as well, I think we can merge. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1166-by-StefanRijnhart-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
… Rename field manufacturer into manufacturer_id
FrancoMaxime
force-pushed
the
16.0-mig-product_manufacturer
branch
from
487a39f to
42b0c06
Compare
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 41edf2b. Thanks a lot for contributing to OCA. ❤️ |
| def create(self, vals_list): | ||
| """Overwrite creation for rewriting manufacturer information (if set and having | ||
| only one variant), after the variant creation, that is performed in super. | ||
| TODO : when migrating in version 16.0, remove the overload of the create function |
There was a problem hiding this comment.
This part has been forgotten.
@FrancoMaxime could you take a look ?
thanks !
There was a problem hiding this comment.
@legalsylvain I will make the fix next week if it is ok for you?
There was a problem hiding this comment.
@legalsylvain I did it, a bit late sorry. Can you take a look at this pr? #1424
#1157