Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] product_template_tag: add parent tags #1505

Merged

Conversation

SilvioC2C
Copy link
Contributor

@SilvioC2C SilvioC2C commented Jan 30, 2024

Forward port of #1504

EDIT: some tests seem to be failing for reasons unrelated to this PR, as they are also currently failing on branch 16.0.

@OCA-git-bot
Copy link
Contributor

Hi @ivantodorovich, @patrickrwilson,
some modules you are maintaining are being modified, check this out!

@gurneyalex
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1505-by-gurneyalex-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 2, 2024
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1505-by-gurneyalex-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk
Copy link
Contributor

tests fixed. Rebase pls

@legalsylvain
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@legalsylvain The rebase process failed, because command git push --force camptocamp tmp-pr-1505:16.0-IMP-add_product_tmpl_tag_parent failed with output:

remote: Permission to camptocamp/product-attribute.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/camptocamp/product-attribute/': The requested URL returned error: 403

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need rebase.

@SilvioC2C SilvioC2C force-pushed the 16.0-IMP-add_product_tmpl_tag_parent branch from 240042f to 60eeb77 Compare March 26, 2024 09:46
@SilvioC2C SilvioC2C force-pushed the 16.0-IMP-add_product_tmpl_tag_parent branch from 60eeb77 to 2297853 Compare March 26, 2024 10:08
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024
@legalsylvain
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1505-by-legalsylvain-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit def9557 into OCA:16.0 Jul 28, 2024
6 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d74d1b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants