Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX]product_supplierinfo_for_customer: apply missed suggestion #1507

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[14.0][FIX]product_supplierinfo_for_customer: apply missed suggestion #1507

merged 1 commit into from
Jan 30, 2024

Conversation

PicchiSeba
Copy link
Contributor

@PicchiSeba PicchiSeba commented Jan 30, 2024 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

Hi @aleuffre, @renda-dev,
some modules you are maintaining are being modified, check this out!

@PicchiSeba PicchiSeba changed the title [FIX]product_supplierinfo_for_customer: apply missed suggestion [14.0][FIX]product_supplierinfo_for_customer: apply missed suggestion Jan 30, 2024
aleuffre
aleuffre suggested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line of a commit message needs to be <= 80 characters.

you can add the link in the body of the commit message

@francesco-ooops
Copy link
Contributor

@pedrobaeza good to go?

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 30, 2024
pedrobaeza
pedrobaeza approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1507-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7b0ebee into OCA:14.0 Jan 30, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 751c2d1. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-apply-missed-suggestion branch January 30, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@PicchiSeba @OCA-git-bot @francesco-ooops @pedrobaeza @aleuffre