Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17][FIX] product_state: Fix rule has no group #1738

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17][FIX] product_state: Fix rule has no group #1738

wants to merge 1 commit into from

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Oct 1, 2024 •
edited
Loading

on rule: product state public

2024-10-01 10:46:34,453 261 WARNING odoo odoo.addons.base.models.ir_model: Rule product.state.public has no group, this is a deprecated feature. Every access-granting rule should specify a group

To silenece warning in odoo logger.

@bosd
product_state: Fix rule has no group
56c0eea 
on rule: product state public
@OCA-git-bot
Copy link
Contributor

Hi @emagdalenaC2i,
some modules you are maintaining are being modified, check this out!

@bosd bosd marked this pull request as ready for review October 1, 2024 11:06
@bosd
Copy link
Contributor Author

bosd commented Oct 1, 2024

@yvaucher Can you please review? 🙏

flotho
flotho approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sense

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvaucher yvaucher yvaucher approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bosd @OCA-git-bot @flotho @yvaucher