Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] product_medical: Migration to 18.0 #1753

Merged
merged 15 commits into from
Dec 24, 2024
Merged

[18.0][MIG] product_medical: Migration to 18.0 #1753

merged 15 commits into from
Dec 24, 2024

Conversation

LucasTran380381
Copy link

@LucasTran380381 LucasTran380381 commented Oct 29, 2024 •
edited
Loading

Changes:

  • remove string redundant in fields
  • remove migrations directory
  • change tree view to list view

@LucasTran380381 LucasTran380381 changed the title 18.0 mig product medical [18.0][MIG] product_medical: Migration to 18.0 Oct 30, 2024
@LucasTran380381 LucasTran380381 mentioned this pull request Oct 30, 2024
Open
25 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration product_medical

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 5, 2024
rousseldenis
rousseldenis approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Even if some fields in product template should maybe include 'medical' in their names to avoid possible conflicts

sebalix
sebalix reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting back on my first review: there are two pre-commit commits, and the 2nd one is bumping the version number wrongly, then it's reverted in the migration commit afterwards. This has to be fixed.

Regarding a "medical" prefix for fields that could conflicts with other non-medical topics, this is a good improvement indeed. Can you handle this with the proper migration script? 🙏

@LucasTran380381 LucasTran380381 marked this pull request as draft December 18, 2024 15:10
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-product_medical branch 3 times, most recently from dc30cd3 to c05b7bc Compare December 19, 2024 11:28
didierdonze and others added 11 commits December 19, 2024 18:31
@didierdonze
Translated using Weblate (German)
2a4fcd2 
Currently translated at 68.3% (28 of 41 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_medical
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_medical/de/
@claudiagn
Added translation using Weblate (Spanish)
9e6626f
@claudiagn
Added translation using Weblate (Catalan)
798025e
[IMP] product_medical: Change in layout, add multiple docs
c9383a2 
1. The layout for the old tab MDR (now called Conformity)
   has been changed to split the fields into two categories:
   conformity-related and documents-related.

2. The two fields storing the "Declaration of Conformity" and
   the "CE Certificate Medical class", that before stored an
   attachment, now allow to store several attachments.
       To make this change, a migration script has been
   provided, because the field names have changed to adhere
   to the naming conventions.

3. The string for the field ce_certificate_medical_class_ids
   has changed from 'CE Certificate Medical class' to 'CE Certificate'.
   The translation files have been updated.
[FIX] product_medical: minor changes in labels
7f0c55a 
- Medical Class -> Medical Device Class
- Medical Category > Drug Category
[IMP] product_medical: views for conformity categories
cda8c41 
The attributes for the Conformity Configuration (Medical Class,
Medical Category, PPE Category, and In Vitro Diagnostics) had no
views associated to them, so the only way of accessing them was
through the entry they have in the form for product.template.

With this PR, tree views and their actions have been added, so
that they can be reused in other modules to accessed them
from custom menu-items.
@dzungtran89
[IMP] product_medical: black, isort, prettier
553c578
@dzungtran89
[MIG] product_medical: Migration to 14.0
d3a3628
@Noel000
Translated using Weblate (Catalan)
ec3efac 
Currently translated at 100.0% (52 of 52 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_medical
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_medical/ca/
@mymage
Added translation using Weblate (Italian)
a0c8d00
@psc
Translated using Weblate (German)
41f8688 
Currently translated at 84.6% (44 of 52 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_medical
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_medical/de/
Ivorra78 and others added 2 commits December 19, 2024 18:32
@Ivorra78
Translated using Weblate (Spanish)
f257dd9 
Currently translated at 100.0% (52 of 52 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_medical
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_medical/es/
[IMP] product_medical: pre-commit auto fixes
4215f74
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-product_medical branch from c05b7bc to 943de0f Compare December 19, 2024 11:32
@LucasTran380381 LucasTran380381 marked this pull request as ready for review December 19, 2024 11:35
@LucasTran380381
Copy link
Author

Getting back on my first review: there are two pre-commit commits, and the 2nd one is bumping the version number wrongly, then it's reverted in the migration commit afterwards. This has to be fixed.

Regarding a "medical" prefix for fields that could conflicts with other non-medical topics, this is a good improvement indeed. Can you handle this with the proper migration script? 🙏

@sebalix thanks for your suggestion. I added migrations script and fixed commit

@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-product_medical branch from 943de0f to cf0503e Compare December 23, 2024 03:39
sebalix
sebalix approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat, LG.
Regarding migration script, I could not test it but if something doesn't work we'll fix it ASAP anyway.

@sebalix
Copy link
Contributor

sebalix commented Dec 24, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1753-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7e9a1c7 into OCA:18.0 Dec 24, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c544846. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@rousseldenis rousseldenis rousseldenis approved these changes

@sebalix sebalix sebalix approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@TDu TDu TDu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.