[18.0][MIG] product_supplierinfo_archive: Migration to 18.0 #1771#1772
[18.0][MIG] product_supplierinfo_archive: Migration to 18.0 #1771#1772
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_supplierinfo_archive Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_supplierinfo_archive/it/
sebalix
left a comment
There was a problem hiding this comment.
You somehow squashed your migration commit into the pre-commit one
|
Actually there was no fix -- the module work out of the box - that why we have only 1 commit. |
|
@sebalix I included the other this clarification on the migration commit because of the lack of pre-commit auto-fixes: |
|
So you don't expect people to bump the version 18.0 before running |
| <field name="inherit_id" ref="product.product_supplierinfo_tree_view" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="price" position="after"> | ||
| <field name="active" invisible="1" /> |
There was a problem hiding this comment.
Missing fields used in domains and other attributes are added to the view as invisible automatically. If you encounter fields in views with invisible="True", they can probably be removed. Reference: odoo/odoo#137031
There was a problem hiding this comment.
@pfranck can you address this comment please? 🙏
Nope, that's the flow. The pre-commit fixes should be applied with the configuration of the destination branch and commited with Then, the migration changes should be applied |
|
Hi @pfranck, @pedrobaeza, @rousseldenis, @sebalix, I created #1825 to take over this PR. |
|
Superseded by #1825 |

No description provided.