[18.0][MIG] product_total_weight_from_packaging: Migration to 18.0 #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
approved these changes
Dec 30, 2024
Comment on lines
6
to
10
| class TestProductTotalWeightFromPackaging(TransactionCase): | ||
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
There was a problem hiding this comment.
Shouldn't this extend TestProductCommon instead ? Then no need for tracking_disable
Suggested change
| class TestProductTotalWeightFromPackaging(TransactionCase): | |
| @classmethod | |
| def setUpClass(cls): | |
| super().setUpClass() | |
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) | |
| from odoo.addons.product.tests.common import TestProductCommon | |
| class TestProductTotalWeightFromPackaging(TestProductCommon): | |
| @classmethod | |
| def setUpClass(cls): | |
| super().setUpClass() |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_total_weight_from_packaging Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_total_weight_from_packaging/
…x_weight The max_weight is a concept that was introduced in odoo delivery module to define the transporter weight limit for the shipped packaging. Before v16, the transporter packaging and product packaging was the same model product.packaging. Now the transporter packaging is moved to the model stock.package.type. In v13, max_weight defined in delivery module on product.packaging was used also for product packaging dimension. In v14, the weight field was added on the product.packaging and the max_weight was still coming from delivery module. This was introducing inconsistency as some modules migrated from v13 to v14 still rely on max_weight and some rely on the new weight field. In v16, we have to drop this max_weight on product.packaging as the delivery module moved it to stock.package.type and we should rely only on the weight field. The migration of the product_packaging_dimension OCA#1161 has to be fixed to not expose the old max_weight field and any data on max_weight must be moved to weight if empty. This module also deserves a big warning that it is lacking the weight uom conversions as it depends on product_packaging_dimension that depends on product_logistics_uom that allows to set a uom on the weight. The sum in this module is assuming all weights are in kg Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
Kimkhoi3010
force-pushed
the
18.0-mig-product_total_weight_from_packaging
branch
from
d8b48f9 to
13f532d
Compare
|
This PR has the |
|
/ocabot migration product_total_weight_from_packaging |
jbaudoux
reviewed
Mar 13, 2025
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "installable": True, | ||
| "depends": ["stock_packaging_calculator", "product_packaging_dimension"], |
There was a problem hiding this comment.
Once OCA/stock-logistics-warehouse#2173 (comment) done
Suggested change
| "depends": ["stock_packaging_calculator", "product_packaging_dimension"], | |
| "depends": ["product_packaging_calculator", "product_packaging_dimension"], |
Kimkhoi3010
force-pushed
the
18.0-mig-product_total_weight_from_packaging
branch
from
13f532d to
f423916
Compare
jbaudoux
approved these changes
Mar 18, 2025
|
pending pr merged |
Kimkhoi3010
force-pushed
the
18.0-mig-product_total_weight_from_packaging
branch
from
f423916 to
3a6303b
Compare
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 4687db4. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.