Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] product_packaging_type_pallet: Migration to 18.0 #1802

Closed

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Dec 5, 2024

grindtildeath and others added 21 commits November 29, 2024 17:21
Currently translated at 100.0% (6 of 6 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_packaging_type_pallet
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_packaging_type_pallet/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/
Currently translated at 100.0% (9 of 9 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/es/
@trisdoan trisdoan mentioned this pull request Dec 5, 2024
45 tasks
ref="product_packaging_type.view_product_packaging_type_form"
/>
<field name="name">stock.package.type.form.inherit</field>
<field name="model">stock.package.type</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename the file stock_package_type.xml accordingly

@@ -3,15 +3,15 @@
from odoo import fields, models


class ProductPackagingType(models.Model):
_inherit = "product.packaging.type"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this, should we rename the module product_packaging_type_pallet to stock_package_type_pallet?
We also have already some stock_package_type_* modules (in v16) hosted in OCA/stock-logistics-warehouse. Should it be moved there?

@jbaudoux @rousseldenis what do you think?

Copy link
Contributor

@jbaudoux jbaudoux Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebalix This module is obsolete. It was a dependency of the reception screen but this is being replaced by shopfloor_reception. At least, that's the plan. And we need to make this configurable on the package type https://github.com/OCA/wms/blob/14.0/shopfloor_reception_packaging_dimension/services/reception.py#L26
so that you can configure on pallet that you only want the height without width/length

@trisdoan trisdoan marked this pull request as draft December 16, 2024 03:11
@trisdoan trisdoan closed this Dec 16, 2024
@trisdoan
Copy link
Contributor Author

Took recommendation from @jbaudoux, this PR should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.