-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] product_packaging_type_pallet: Migration to 18.0 #1802
[18.0][MIG] product_packaging_type_pallet: Migration to 18.0 #1802
Conversation
Currently translated at 100.0% (6 of 6 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_packaging_type_pallet Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_packaging_type_pallet/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/
Currently translated at 100.0% (9 of 9 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/it/
Currently translated at 100.0% (9 of 9 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/it/
Currently translated at 100.0% (9 of 9 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_packaging_type_pallet Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_packaging_type_pallet/es/
ref="product_packaging_type.view_product_packaging_type_form" | ||
/> | ||
<field name="name">stock.package.type.form.inherit</field> | ||
<field name="model">stock.package.type</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename the file stock_package_type.xml
accordingly
@@ -3,15 +3,15 @@ | |||
from odoo import fields, models | |||
|
|||
|
|||
class ProductPackagingType(models.Model): | |||
_inherit = "product.packaging.type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this, should we rename the module product_packaging_type_pallet
to stock_package_type_pallet
?
We also have already some stock_package_type_*
modules (in v16) hosted in OCA/stock-logistics-warehouse. Should it be moved there?
@jbaudoux @rousseldenis what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebalix This module is obsolete. It was a dependency of the reception screen but this is being replaced by shopfloor_reception. At least, that's the plan. And we need to make this configurable on the package type https://github.com/OCA/wms/blob/14.0/shopfloor_reception_packaging_dimension/services/reception.py#L26
so that you can configure on pallet that you only want the height without width/length
Took recommendation from @jbaudoux, this PR should be closed |
Note