[16.0][ADD] product_merge #1830

sbejaoui · 2025-01-02T15:59:27Z

This module allows users to efficiently merge multiple product templates into one. This merge process ensures that attributes and variants from all selected products are consolidated into the primary product template, without creating any new variants. This approach is particularly important for maintaining data integrity and avoiding unnecessary database load.

By not creating new variants during the merge, the module helps to prevent heavy updates on existing tables, making it ideal for large-scale databases.

sale_product_merge/wizards/product_merge_wizard.py

product_merge/wizards/product_merge_wizard.py

StefanRijnhart · 2025-01-19T17:47:05Z

Possible duplicate of https://github.com/OCA/stock-logistics-warehouse/tree/16.0/base_product_merge?

StefanRijnhart · 2025-01-19T17:48:43Z

This module emits error logs during the tests. Can you mute the logger when testing the exception?

2025-01-07T23:29:23.6985267Z 2025-01-07 23:29:23,697 500 �[1;32m�[1;49mINFO�[0m odoo odoo.addons.product_merge.tests.test_product_merge: Starting TestProductMerge.test_action_merge_products_same_attribute_value ... 
2025-01-07T23:29:23.7717242Z 2025-01-07 23:29:23,770 500 �[1;31m�[1;49mERROR�[0m odoo odoo.sql_db: bad query: UPDATE "product_product" SET "combination_indices" = '20', "write_date" = '2025-01-07T23:29:23.397594'::timestamp, "write_uid" = 1 WHERE id IN (78)
2025-01-07T23:29:23.7718580Z ERROR: duplicate key value violates unique constraint "product_product_combination_unique"
2025-01-07T23:29:23.7719177Z DETAIL:  Key (product_tmpl_id, combination_indices)=(63, 20) already exists.
2025-01-07T23:29:23.7719532Z

StefanRijnhart

See comments above.

lmignon · 2025-01-22T13:37:53Z

Possible duplicate of https://github.com/OCA/stock-logistics-warehouse/tree/16.0/base_product_merge?

The goal is not the same. This PR propose to merge 2 product templates into one product with 2 variants.

StefanRijnhart · 2025-01-22T13:57:04Z

From what I can see, base_product_merge will not merge product variants if there are product attributes at play, in which case the result is also one product with the combined set of variants. Can you be more precise about the difference in outcome?

lmignon · 2025-01-22T14:28:32Z

From what I can see, base_product_merge will not merge product variants if there are product attributes at play, in which case the result is also one product with the combined set of variants. Can you be more precise about the difference in outcome?

I didn't know that the base_product_merge module existed so I didn't really test it.
A typical use case is, for example, when you have two TShirt products in DB, one for TShirt M and one for TShirt L, which are not variants of each other. The wizard will allow you to group the products together under the same template while completing the attribute values possible at template level. I don't get the impression from reading the code of the base_product_merge module that this is the use case supported.
Moreover we avoid modifying the variant identifiers. We're trying to minimize the impact on the DB as much as possible by keeping the current variant identifiers and only replacing the values of the template that has been orphaned by its variant. The merge must be possible on a running instance with a lot of sales and logistics activities.

StefanRijnhart · 2025-01-22T14:41:28Z

Sounds like there is a strong case to try and improve base_product_merge for this scenario, also given that it already uses OpenUpgradelib's merge_records.

chienandalu · 2025-03-13T08:05:43Z

product_merge/wizards/product_merge_wizard.py

+            other_templates.ids,
+            self.product_tmpl_id.id,
+            field_spec=self._get_merge_field_spec(),
+            delete=False,


Out of curiosity. Why to keep the old template?

As a merge strategy, we chose to keep the target values. This behavior can be modified through inheritance of _get_merge_field_spec. However, after the merge, the user may need to check one of the merged products to see, for example, the previous price or any other useful data.

That’s why we archive the merged products and leave the cleanup to the user if they wish to do so.

rousseldenis

Seems great.

product_merge/wizards/product_merge_wizard.py

product_merge/wizards/product_merge_wizard_line.py

rousseldenis · 2025-03-13T13:49:12Z

product_merge/wizards/product_merge_wizard.py

+        Ensure that at least two products are selected for merging.
+        """
+        for wizard in self:
+            if len(wizard.product_ids) < 2:


An alert should be great on wizard form in order to warn user before clicking on merge.

This check can't be done before the user completes their input
otherwise, they would receive a warning after adding the first product
IMO, it makes sense to trigger it when they click on the button

This module allows users to efficiently merge multiple product templates into one. This merge process ensures that attributes and variants from all selected products are consolidated into the primary product template, without creating any new variants. This approach is particularly important for maintaining data integrity and avoiding unnecessary database load. By not creating new variants during the merge, the module helps to prevent heavy updates on existing tables, making it ideal for large-scale databases.

github-actions · 2025-08-03T12:24:30Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

PieterPaulussen · 2025-08-12T13:37:05Z

@sbejaoui Any chance that you could create another PR for V18?

github-actions · 2025-12-21T12:23:37Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

nihelgabsi-acsone

Functional Test + Code review

sbejaoui force-pushed the 16.0-product_merge-sbj branch from eed5099 to b3efaff Compare January 7, 2025 23:26

chienandalu reviewed Jan 10, 2025

View reviewed changes

sale_product_merge/wizards/product_merge_wizard.py Outdated Show resolved Hide resolved

lmignon suggested changes Jan 14, 2025

View reviewed changes

product_merge/wizards/product_merge_wizard.py Show resolved Hide resolved

StefanRijnhart reviewed Jan 19, 2025

View reviewed changes

PieterPaulussen mentioned this pull request Jan 30, 2025

[MIG] base_product_merge: Migration to 18.0 OCA/stock-logistics-warehouse#2250

Closed

sbejaoui force-pushed the 16.0-product_merge-sbj branch 4 times, most recently from 50bf43a to 477680a Compare March 13, 2025 00:53

chienandalu reviewed Mar 13, 2025

View reviewed changes

rousseldenis added the needs review label Mar 13, 2025

rousseldenis added this to the 16.0 milestone Mar 13, 2025

rousseldenis reviewed Mar 13, 2025

View reviewed changes

sbejaoui force-pushed the 16.0-product_merge-sbj branch from 0defc7f to 6d06571 Compare March 14, 2025 16:23

sbejaoui force-pushed the 16.0-product_merge-sbj branch from 6d06571 to 61e45b8 Compare March 14, 2025 16:29

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 3, 2025

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 17, 2025

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 21, 2025

nihelgabsi-acsone approved these changes Jan 19, 2026

View reviewed changes

Uh oh!

[16.0][ADD] product_merge #1830

Are you sure you want to change the base?

[16.0][ADD] product_merge #1830

Conversation

sbejaoui commented Jan 2, 2025

Uh oh!

Uh oh!

Uh oh!

StefanRijnhart commented Jan 19, 2025

Uh oh!

StefanRijnhart commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

lmignon commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmignon commented Jan 22, 2025

Uh oh!

StefanRijnhart commented Jan 22, 2025

Uh oh!

chienandalu Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

sbejaoui Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rousseldenis Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

sbejaoui Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 3, 2025

Uh oh!

PieterPaulussen commented Aug 12, 2025

Uh oh!

github-actions bot commented Dec 21, 2025

Uh oh!

nihelgabsi-acsone left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

StefanRijnhart commented Jan 19, 2025 •

edited

Loading

lmignon commented Jan 22, 2025 •

edited

Loading

StefanRijnhart commented Jan 22, 2025 •

edited

Loading