[18.0] [MIG] product_configurator_mrp: Migration to 18.0 #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de translations of product_configurator (Pledra)
* Flake8 fixes
…igurator_mrp : correct method-name, claas-name, arguments
…production_lots, fix singleton error(product.config.step.line)
…igurator_mrp : correct method-name, claas-name, arguments
…production_lots, fix singleton error(product.config.step.line)
This commit fixes the error received when finishing a configuration and it tries to create or write of the mrp order
…ible when not in draft state
[IMP] Add Bom Line if no config_id [FIX] Removed unused UserError [IMP] Better config set attribute matching [FIX] Travis [IMP] Don't create bom if no bom lines [FIX] no bom line if
…t should copy over the operations from the master BOM
Co-authored-by: Daniel Reis <[email protected]>
Correction of bug access key "product_qty" not in dictionary
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_mrp Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_mrp/
Currently translated at 100.0% (47 of 47 strings) Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_mrp Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_mrp/it/
ivantodorovich
approved these changes
Mar 17, 2025
Comment on lines
5
to
6
| patch(FormController.prototype, {}); | ||
| applyConfigButtonMixin(FormController.prototype, ".o_form_button_create_config"); |
There was a problem hiding this comment.
With the current mixin approach, patch seems pointless here, isn't it?
I would recommend, though, rather than removing it, do a refactoring on the mixin to return a patch-like object and use it (roughly) like this:
// config_button_mixin.esm.js
export function ConfigButtonMixin(buttonSelector) {
return {
setup() {
super.setup();
// do stuff
},
async _onConfigure() {
// do stuff
}
}
}// form_controller.esm.js
patch(FormController.prototype, ConfigButtonMixin(".o_form_button_create_config"))Here's an example of this pattern in upstream code: https://github.com/odoo/odoo/blob/0bc69d757f7c3429c6112aa5aaa1ceb999428189/addons/mail/static/src/js/onchange_on_keydown.js#L42
| import {patch} from "@web/core/utils/patch"; | ||
|
|
||
| patch(KanbanController.prototype, {}); | ||
| applyConfigButtonMixin(KanbanController.prototype, ".o-kanban-button-new_config"); |
| import {patch} from "@web/core/utils/patch"; | ||
|
|
||
| patch(ListController.prototype, {}); | ||
| applyConfigButtonMixin(ListController.prototype, ".o_list_button_add_config"); |
Comment on lines
82
to
83
| "Please inform the administrator/manager. [Product: {}]" | ||
| ).format(product_name) |
There was a problem hiding this comment.
Suggested change
| "Please inform the administrator/manager. [Product: {}]" | |
| ).format(product_name) | |
| "Please inform the administrator/manager. [Product: %s]", | |
| product_name | |
| ) |
bizzappdev
force-pushed
the
18.0-mig-product_configurator_mrp-BAD
branch
from
a4d6c21 to
bde2dab
Compare
|
@ivantodorovich Thank you for the review. changes are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency PR for module product_configurator #150