-
-
Notifications
You must be signed in to change notification settings - Fork 827
[15.0][MIG] project_key #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] project_key #1055
Conversation
/ocabot migration project_key |
f797355
to
6a985e1
Compare
Currently translated at 100.0% (9 of 9 strings) Translation: project-12.0/project-12.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_key/de/
Currently translated at 100.0% (9 of 9 strings) Translation: project-12.0/project-12.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_key/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-13.0/project-13.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_key/
Currently translated at 75.0% (9 of 12 strings) Translation: project-14.0/project-14.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_key/fr/
Currently translated at 83.3% (10 of 12 strings) Translation: project-14.0/project-14.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_key/it/
6a985e1
to
3040aaf
Compare
a project, must be linked to the project company to avoid security issues.
@@ -13,7 +13,7 @@ class Project(models.Model): | |||
comodel_name="ir.sequence", string="Key Sequence", ondelete="restrict" | |||
) | |||
|
|||
key = fields.Char(string="Key", size=10, required=False, index=True, copy=False) | |||
key = fields.Char(size=10, required=False, index=True, copy=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tanks for this @vincent-hatakeyama
I only see a small error from a previous migration:
Remove size=X attribute in Char fields, as it's no longer valid for restricting the size of the strings.
see: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0
Functionally it is Ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s strange because in Odoo 14, size is used on the attachment’s checksum : https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L393
In the database, the type of the column is character varying(40)
.
(the url is also defined as size 1024 and the information is found on the database too)
That’s still the case with Odoo 15 and 16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see it here: https://github.com/odoo/odoo/blob/14.0/odoo/fields.py#L1624
You can leave it for me, it can be removed in the next version.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
I’ve added the fix from #1072 as suggested. |
@vincent-hatakeyama @pedrobaeza |
See #1169 |
Thanks for getting me the code for v16. |
This is the migration for Odoo 15; it just hasn’t been merged in OCA. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
I’ve just rebase this. @OCA/project-service-maintainers It would be nice if this was merged since the 16.0 version is also merged. |
This PR can't be reopened. |
Standard migration of the project_key module.