Skip to content

[15.0][MIG] project_key #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vincent-hatakeyama
Copy link
Contributor

@vincent-hatakeyama vincent-hatakeyama commented Jan 19, 2023

Standard migration of the project_key module.

@simahawk
Copy link
Contributor

/ocabot migration project_key

pnajman-modoolar and others added 25 commits February 23, 2023 16:58
Currently translated at 100.0% (9 of 9 strings)

Translation: project-12.0/project-12.0-project_key
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_key/de/
Currently translated at 100.0% (9 of 9 strings)

Translation: project-12.0/project-12.0-project_key
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_key/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_key
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_key/
@vincent-hatakeyama vincent-hatakeyama force-pushed the 15.0-mig-project_key-and-history branch from 6a985e1 to 3040aaf Compare February 23, 2023 15:58
a project, must be linked to the project company to avoid security
issues.
@@ -13,7 +13,7 @@ class Project(models.Model):
comodel_name="ir.sequence", string="Key Sequence", ondelete="restrict"
)

key = fields.Char(string="Key", size=10, required=False, index=True, copy=False)
key = fields.Char(size=10, required=False, index=True, copy=False)
Copy link
Member

@zamberjo zamberjo Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks for this @vincent-hatakeyama

I only see a small error from a previous migration:
Remove size=X attribute in Char fields, as it's no longer valid for restricting the size of the strings.

see: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0

Functionally it is Ok for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s strange because in Odoo 14, size is used on the attachment’s checksum : https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L393
In the database, the type of the column is character varying(40).
(the url is also defined as size 1024 and the information is found on the database too)

That’s still the case with Odoo 15 and 16.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see it here: https://github.com/odoo/odoo/blob/14.0/odoo/fields.py#L1624

You can leave it for me, it can be removed in the next version.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 27, 2023
@vincent-hatakeyama
Copy link
Contributor Author

I’ve added the fix from #1072 as suggested.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 17, 2023
@jcfernandez-890825
Copy link

jcfernandez-890825 commented Oct 20, 2023

@vincent-hatakeyama @pedrobaeza
Is this module gonna be migrated to v15 and v16 ?

@zamberjo
Copy link
Member

@vincent-hatakeyama @pedrobaeza Is this module gonna be migrated to v15 and v16 ?

See #1169

@jcfernandez-890825
Copy link

@zamberjo

Thanks for getting me the code for v16.
So this module is just pending to be merged on v15 and v16?

@vincent-hatakeyama
Copy link
Contributor Author

Is this module gonna be migrated to v15 and v16 ?

This is the migration for Odoo 15; it just hasn’t been merged in OCA.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2024
@github-actions github-actions bot closed this Mar 24, 2024
@vincent-hatakeyama
Copy link
Contributor Author

I’ve just rebase this.

@OCA/project-service-maintainers It would be nice if this was merged since the 16.0 version is also merged.

@dreispt
Copy link
Member

dreispt commented Mar 29, 2024

This PR can't be reopened.
Can you create a new one please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.